Skip to content

rustdoc: Styling regressions from stable to beta #87072

@camelid

Description

@camelid
Member

Regression 1

Ayu-only. The summary in the search results is now blue, when it used to be white.

beta (incorrect)

image

stable (correct)

image

Regression 2

Ayu-only. The color of impls in Ayu has changed from white to yellow. This may be intentional, but it looked off when I saw it. Note that this happens for all impls, not just foreign impls.

beta (incorrect)

image

stable (correct)

image

Regression 3

All themes. Certain auto-trait, foreign, unconditional impls have underlines.

beta (incorrect)

image

stable (correct)

image

Regression 4

All themes. The phrase (keyword) next to match in the search results is now red in addition to match itself being red, whereas (keyword) used to be gray.

beta (incorrect)

image

stable (correct)

image

Meta

All of the regressions seem to have occurred in beta (1.54.0).

Activity

added
T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
C-bugCategory: This is a bug.
A-rustdoc-uiArea: Rustdoc UI (generated HTML)
on Jul 12, 2021
added this to the 1.54.0 milestone on Jul 12, 2021
added
I-prioritizeIssue: Indicates that prioritization has been requested for this issue.
on Jul 12, 2021
GuillaumeGomez

GuillaumeGomez commented on Jul 12, 2021

@GuillaumeGomez
Member

Regression 3 is fixed in #87035.

GuillaumeGomez

GuillaumeGomez commented on Jul 12, 2021

@GuillaumeGomez
Member

Sending a fix for the three others.

GuillaumeGomez

GuillaumeGomez commented on Jul 12, 2021

@GuillaumeGomez
Member

Regressions 1 and 4 are fixed in #87085.

added 2 commits that reference this issue on Jul 13, 2021
1d8d084
b242ff7
added 2 commits that reference this issue on Jul 13, 2021
baf23b8
fc488d4
added a commit that references this issue on Jul 14, 2021
e0d72d0
removed
I-prioritizeIssue: Indicates that prioritization has been requested for this issue.
on Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-rustdoc-uiArea: Rustdoc UI (generated HTML)C-bugCategory: This is a bug.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      Participants

      @GuillaumeGomez@apiraino@camelid@rustbot

      Issue actions

        rustdoc: Styling regressions from stable to beta · Issue #87072 · rust-lang/rust