-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Closed
Labels
A-rustdoc-uiArea: Rustdoc UI (generated HTML)Area: Rustdoc UI (generated HTML)C-bugCategory: This is a bug.Category: This is a bug.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.
Milestone
Description
Regression 1
Ayu-only. The summary in the search results is now blue, when it used to be white.
beta (incorrect)
stable (correct)
Regression 2
Ayu-only. The color of impls in Ayu has changed from white to yellow. This may be intentional, but it looked off when I saw it. Note that this happens for all impls, not just foreign impls.
beta (incorrect)
stable (correct)
Regression 3
All themes. Certain auto-trait, foreign, unconditional impls have underlines.
beta (incorrect)
stable (correct)
Regression 4
All themes. The phrase (keyword)
next to match
in the search results is now red in addition to match
itself being red, whereas (keyword)
used to be gray.
beta (incorrect)
stable (correct)
Meta
All of the regressions seem to have occurred in beta (1.54.0).
Metadata
Metadata
Assignees
Labels
A-rustdoc-uiArea: Rustdoc UI (generated HTML)Area: Rustdoc UI (generated HTML)C-bugCategory: This is a bug.Category: This is a bug.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.
Type
Projects
Relationships
Development
Select code repository
Activity
GuillaumeGomez commentedon Jul 12, 2021
Regression 3 is fixed in #87035.
GuillaumeGomez commentedon Jul 12, 2021
Sending a fix for the three others.
GuillaumeGomez commentedon Jul 12, 2021
Regressions 1 and 4 are fixed in #87085.
Rollup merge of rust-lang#87085 - GuillaumeGomez:search-result-colors…
Rollup merge of rust-lang#87085 - GuillaumeGomez:search-result-colors…
Rollup merge of rust-lang#87085 - GuillaumeGomez:search-result-colors…
Rollup merge of rust-lang#87085 - GuillaumeGomez:search-result-colors…
Rollup merge of rust-lang#87125 - GuillaumeGomez:ayu-code-color, r=no…