Skip to content

LLD is not available with download-ci-llvm #88941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Aaron1011 opened this issue Sep 14, 2021 · 1 comment · Fixed by #91229
Closed

LLD is not available with download-ci-llvm #88941

Aaron1011 opened this issue Sep 14, 2021 · 1 comment · Fixed by #91229
Labels
A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@Aaron1011
Copy link
Member

When download-ci-llvm=true is set, lld is not available in build/x86_64-unknown-linux-gnu/ci-llvm/bin. This makes it more difficult to use a stage1 compiler to cross-compile to platforms that use LLD by default (like wasm32-unknonwn-unknown), as the linker needs to be manually overridden in a .cargo/config file.

If we have the CI budget available, it would be useful to build LLD along with LLVM, and make it available in the archive downloaded by x.py.
@Aaron1011 Aaron1011 added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust labels Sep 14, 2021
@Mark-Simulacrum
Copy link
Member

We just need to adjust the component creation to include LLD -- at least on x86_64-unknown-linux-gnu it's already built.

@Aaron1011 Aaron1011 mentioned this issue Nov 25, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Dec 5, 2021
@bors
Auto merge of rust-lang#91229 - Aaron1011:dist-lld, r=Mark-Simulacrum
6c189bc 
Include `lld` in `rust-dev` package

Fixes rust-lang#88941

This will allow using `download-ci-llvm` while still having LLD
available.
@bors bors closed this as completed in 7826c57 Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include lld in rust-dev package Aaron1011/rust
2 participants
@Aaron1011 @Mark-Simulacrum