Skip to content

perf regression for doc generation from rollup 90416 #90512

Open
@pnkfelix

Description

Activity

added
I-slowIssue: Problems and improvements with respect to performance of generated code.
T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
on Nov 2, 2021
pnkfelix

pnkfelix commented on Nov 2, 2021

@pnkfelix
MemberAuthor

(spoke to @GuillaumeGomez , who hypothesizes based on the contents of Pull Request #90416 that this is a spurious regression.)

camelid

camelid commented on Nov 2, 2021

@camelid
Member

I wonder if it's possible that something in rustc changed that is only used by rustdoc, so the regression only showed up in doc builds?

camelid

camelid commented on Nov 2, 2021

@camelid
Member

I looked through the rollup diff. None of the compiler changes (and certainly not the rustdoc) changes jump out at me as potentially causing this regression. #90377 doesn't seem likely either, since I don't think it'd affect rustdoc differently from the compiler.

However, I wonder if the regression could be due to #89876. It makes some core internal macros more complex and adds attributes to a bunch of core traits, which could be slowing rustdoc down (especially since impls and traits are one of the slowest parts of rustdoc). It still seems like a bit of a stretch though to cause such huge regressions.

Also, the most significant regressions are for doc builds, but there are non-trivial regressions on check (and maybe other) builds too (EDIT: the check regressions show up even with "Filter out very small changes" checked):

image

jyn514

jyn514 commented on Nov 2, 2021

@jyn514
Member

I wonder if it makes sense not to investigate too heavily for helloworld regressions. Rustdoc has lots of global analysis which I've been meaning to look at to see if it's truly necessary, but I don't think there's much we can do to avoid regressions like this in the short-term.

camelid

camelid commented on Nov 2, 2021

@camelid
Member

I wonder if it makes sense not to investigate too heavily for helloworld regressions.

I agree about helloworld, but real-world crates regressed a lot too. E.g., ripgrep and futures regressed by about 1.75%.

camelid

camelid commented on Nov 9, 2021

@camelid
Member

Looking at the query diff view, build_extern_trait_impl and metadata_decode_entry_item_attrs both seem to have regressed by several percentage points.

added
C-optimizationCategory: An issue highlighting optimization opportunities or PRs implementing such
on Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-optimizationCategory: An issue highlighting optimization opportunities or PRs implementing suchI-slowIssue: Problems and improvements with respect to performance of generated code.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @pnkfelix@jyn514@camelid@workingjubilee

        Issue actions

          perf regression for doc generation from rollup 90416 · Issue #90512 · rust-lang/rust