-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Description
I tried to build on a new machine. Got this message:
thread 'main' panicked at '
couldn't find required command: "cmake"
'
Which I'm used to.
I googled a bit, installed cmake
, figured out how to get PATH set up, et cetera.
Then I built again. And got this:
Couldn't find required command: ninja (or ninja-build)
You should install ninja as described at
<https://github.com/ninja-build/ninja/wiki/Pre-built-Ninja-packages>,
or set `ninja = false` in the `[llvm]` section of `config.toml`.
Alternatively, set `download-ci-llvm = true` in that `[llvm]` section
to download LLVM rather than building it.
I'm not sure, but: Isn't cmake
solely necessary in our build for building LLVM? if that's the case, then shouldn't both the cmake
failure and the ninja
failure be providing the same level of feedback (namely, suggesting that one side-step building LLVM altogether as an alternative option to downloading and installing cmake
)?
(Or is the assumption here that cmake
will be used by so many crates, people should just bite bullet and install it? Even so, we could give better guidance up front about where to look for it.)
Metadata
Metadata
Assignees
Labels
A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
jyn514 commentedon Nov 8, 2021
@pnkfelix I don't think cmake intentionally has a worse error, it's just that a bunch of people building from source for the first time have been confused what ninja is and where to get it. If you made a PR improving the error for cmake I'd approve it :)
jyn514 commentedon Mar 29, 2022
@rustbot label: +E-easy
b-NC commentedon Mar 30, 2022
@rustbot claim
thatzopoulos commentedon Apr 30, 2022
Hello @InfRandomness, I'd like to claim this issue if you're interested in releasing it.
b-NC commentedon May 1, 2022
Sorry about that 😀
Gave it a try but got sidetracked and wasn't really interested in doing it anymore
thatzopoulos commentedon May 1, 2022
@rustbot claim
Auto merge of rust-lang#96659 - thatzopoulos:issue-90679-fix, r=Mark-…
1 remaining item