Skip to content

rls no longer builds after rust-lang/rust#91539 #91543

@rust-highfive

Description

@rust-highfive
Contributor

Hello, this is your friendly neighborhood mergebot.
After merging PR #91539, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @matthiaskrgr, do you think you would have time to do the follow-up work?
If so, that would be great!

Activity

matthiaskrgr

matthiaskrgr commented on Dec 5, 2021

@matthiaskrgr
Member

This might be due to #91355
rustc-ap-rustc_span v722.0.0 no longer builds:

error[E0635]: unknown feature `thread_local_const_init`
  --> /home/matthias/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_span-722.0.0/src/lib.rs:23:12
   |
23 | #![feature(thread_local_const_init)]
   |            ^^^^^^^^^^^^^^^^^^^^^^^

We need a new version I think.
The last published version of https://crates.io/crates/rustc-ap-rustc_span is 5 months old already 🤔
@alexcrichton Can you please check why there are no new rustc-ap versions being published?

added a commit that references this issue on Dec 6, 2021
85a1d67
added a commit that references this issue on Dec 7, 2021
calebcartwright

calebcartwright commented on Dec 8, 2021

@calebcartwright
Member

alexcrichton Can you please check why there are no new rustc-ap versions being published?

https://github.com/alexcrichton/rustc-auto-publish/actions/workflows/main.yml

This scheduled workflow is disabled because there hasn't been activity in this repository for at least 60 days. Enable this workflow to resume scheduled runs.

TIL scheduled GitHub Action Workflows apparently require regular activity in the repository to keep going 👀

alexcrichton

alexcrichton commented on Dec 13, 2021

@alexcrichton
Member

I didn't realize anyone was still using those crates so I disabled the action, I believe it was broken anyway. Does rustfmt and/or other crates still use those crates.io packages? If so I can try to find time to restart the action.

flip1995

flip1995 commented on Dec 13, 2021

@flip1995
Member

Racer still uses those crates. And RLS depends on Racer. So without those crates compiling racer with the latest nightly isn't possible, which makes compiling RLS impossible and therefore blocks the sync of RLS back to rust-lang/rust.

flip1995

flip1995 commented on Dec 13, 2021

@flip1995
Member

Would it maybe be an option to make racer depend on rustc-dev to compile instead of publishing AP crates?

3 remaining items

Mark-Simulacrum

Mark-Simulacrum commented on Dec 13, 2021

@Mark-Simulacrum
Member

@alexcrichton let's sync up on #t-infra on Zulip -- I think it makes sense to move these crates into infra control/publication.

flip1995

flip1995 commented on Dec 13, 2021

@flip1995
Member

Let's wait if Racer can move over to rustc-dev racer-rust/racer#1174. If so, there shouldn't be a need to keep maintaining rustc-ap crates at all. Looking at the dependents on crates.io, there really is only racer, the rustc-ap crates themselves and rustfmt-nightly (which by now uses rustc-dev).

calebcartwright

calebcartwright commented on Dec 13, 2021

@calebcartwright
Member

#88867 has some relevant considerations as well. One way or another I think the AP crates need to be accounted for as per the accepted RFC, though it certainly would be a simpler story if they no longer need to be updated/published

alexcrichton

alexcrichton commented on Dec 13, 2021

@alexcrichton
Member

Happy to coordinate as necessary, just let me know!

added this to the 1.59.0 milestone on Dec 14, 2021
ThatAnonyG

ThatAnonyG commented on Jan 13, 2022

@ThatAnonyG

Over a month now. Is this gonna be fixed?

mati865

mati865 commented on Jan 13, 2022

@mati865
Member
added a commit that references this issue on Jan 16, 2022
1fbd6ae
added a commit that references this issue on Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

C-bugCategory: This is a bug.

Type

No type

Projects

No projects

Relationships

None yet

    Development

    Participants

    @alexcrichton@matthiaskrgr@mati865@Xanewok@Mark-Simulacrum

    Issue actions

      `rls` no longer builds after rust-lang/rust#91539 · Issue #91543 · rust-lang/rust