You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, this is your friendly neighborhood mergebot.
After merging PR #91539, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.
cc @matthiaskrgr, do you think you would have time to do the follow-up work?
If so, that would be great!
This scheduled workflow is disabled because there hasn't been activity in this repository for at least 60 days. Enable this workflow to resume scheduled runs.
TIL scheduled GitHub Action Workflows apparently require regular activity in the repository to keep going 👀
I didn't realize anyone was still using those crates so I disabled the action, I believe it was broken anyway. Does rustfmt and/or other crates still use those crates.io packages? If so I can try to find time to restart the action.
Racer still uses those crates. And RLS depends on Racer. So without those crates compiling racer with the latest nightly isn't possible, which makes compiling RLS impossible and therefore blocks the sync of RLS back to rust-lang/rust.
Let's wait if Racer can move over to rustc-dev racer-rust/racer#1174. If so, there shouldn't be a need to keep maintaining rustc-ap crates at all. Looking at the dependents on crates.io, there really is only racer, the rustc-ap crates themselves and rustfmt-nightly (which by now uses rustc-dev).
#88867 has some relevant considerations as well. One way or another I think the AP crates need to be accounted for as per the accepted RFC, though it certainly would be a simpler story if they no longer need to be updated/published
Activity
matthiaskrgr commentedon Dec 5, 2021
This might be due to #91355
rustc-ap-rustc_span v722.0.0
no longer builds:We need a new version I think.
The last published version of https://crates.io/crates/rustc-ap-rustc_span is 5 months old already 🤔
@alexcrichton Can you please check why there are no new
rustc-ap
versions being published?Rollup merge of rust-lang#91590 - flip1995:clippyup, r=Manishearth
Auto merge of rust-lang#91590 - flip1995:clippyup, r=Manishearth
calebcartwright commentedon Dec 8, 2021
https://github.com/alexcrichton/rustc-auto-publish/actions/workflows/main.yml
TIL scheduled GitHub Action Workflows apparently require regular activity in the repository to keep going 👀
alexcrichton commentedon Dec 13, 2021
I didn't realize anyone was still using those crates so I disabled the action, I believe it was broken anyway. Does rustfmt and/or other crates still use those crates.io packages? If so I can try to find time to restart the action.
flip1995 commentedon Dec 13, 2021
Racer still uses those crates. And RLS depends on Racer. So without those crates compiling racer with the latest nightly isn't possible, which makes compiling RLS impossible and therefore blocks the sync of RLS back to rust-lang/rust.
flip1995 commentedon Dec 13, 2021
Would it maybe be an option to make racer depend on
rustc-dev
to compile instead of publishing AP crates?3 remaining items
Mark-Simulacrum commentedon Dec 13, 2021
@alexcrichton let's sync up on #t-infra on Zulip -- I think it makes sense to move these crates into infra control/publication.
flip1995 commentedon Dec 13, 2021
Let's wait if Racer can move over to rustc-dev racer-rust/racer#1174. If so, there shouldn't be a need to keep maintaining rustc-ap crates at all. Looking at the dependents on crates.io, there really is only
racer
, therustc-ap
crates themselves andrustfmt-nightly
(which by now usesrustc-dev
).calebcartwright commentedon Dec 13, 2021
#88867 has some relevant considerations as well. One way or another I think the AP crates need to be accounted for as per the accepted RFC, though it certainly would be a simpler story if they no longer need to be updated/published
alexcrichton commentedon Dec 13, 2021
Happy to coordinate as necessary, just let me know!
ThatAnonyG commentedon Jan 13, 2022
Over a month now. Is this gonna be fixed?
mati865 commentedon Jan 13, 2022
@ThatAnonyG it's blocked on racer-rust/racer#1174
Auto merge of rust-lang#92935 - Xanewok:update-rls, r=pietroalbini
chore: bump toolchain