Skip to content

consider giving precedence to --config over RUST_BOOTSTRAP_CONFIG #93725

@jyn514

Description

@jyn514
Member

# Read from `RUST_BOOTSTRAP_CONFIG`, then `--config`, then fallback to `config.toml` (if it
# exists).
toml_path = os.getenv('RUST_BOOTSTRAP_CONFIG') or args.config
if not toml_path and os.path.exists('config.toml'):
toml_path = 'config.toml'

It seems pretty strange to me that the env variable would take precedence over --config. It would be nice to switch the precedence.

cc @Mark-Simulacrum

Originally posted by @jyn514 in #92260 (comment)

Activity

added
T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
on Feb 7, 2022
Mark-Simulacrum

Mark-Simulacrum commented on Feb 7, 2022

@Mark-Simulacrum
Member

Added in #73317; it seems like it makes sense for --config to override, though probably not typically all that useful. Happy to see a PR, should be pretty easy so marking as such.

added
E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
on Feb 7, 2022
mfrw

mfrw commented on Feb 7, 2022

@mfrw
Contributor

@rustbot claim

added a commit that references this issue on Feb 7, 2022
a6c4810
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @mfrw@Mark-Simulacrum@jyn514

    Issue actions

      consider giving precedence to `--config` over RUST_BOOTSTRAP_CONFIG · Issue #93725 · rust-lang/rust