-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Description
rust/src/bootstrap/bootstrap.py
Lines 1224 to 1228 in 7b43cfc
# Read from `RUST_BOOTSTRAP_CONFIG`, then `--config`, then fallback to `config.toml` (if it | |
# exists). | |
toml_path = os.getenv('RUST_BOOTSTRAP_CONFIG') or args.config | |
if not toml_path and os.path.exists('config.toml'): | |
toml_path = 'config.toml' |
It seems pretty strange to me that the env variable would take precedence over --config. It would be nice to switch the precedence.
Originally posted by @jyn514 in #92260 (comment)
Metadata
Metadata
Assignees
Labels
E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
Mark-Simulacrum commentedon Feb 7, 2022
Added in #73317; it seems like it makes sense for --config to override, though probably not typically all that useful. Happy to see a PR, should be pretty easy so marking as such.
mfrw commentedon Feb 7, 2022
@rustbot claim
Rollup merge of rust-lang#93737 - mfrw:mfrw/bootstrap-config, r=Mark-…