-
Notifications
You must be signed in to change notification settings - Fork 13.8k
Closed
Labels
A-grammarArea: The grammar of RustArea: The grammar of RustE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone
Metadata
Metadata
Assignees
Labels
A-grammarArea: The grammar of RustArea: The grammar of RustE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Type
Projects
Relationships
Development
Select code repository
Activity
erickt commentedon Sep 24, 2013
I thought we were going to grow a macro to handle block quotes. Did that ever get implemented?
brson commentedon Sep 25, 2013
@erickt I don't know what you mean by block quotes.
catamorphism commentedon Sep 26, 2013
Accepted for feature-complete
ben0x539 commentedon Sep 27, 2013
Don't line comments address pretty much all uses of nested block comments?
erickt commentedon Sep 27, 2013
@brson: by block quote, I mean in the style of CPP's
#ifdef 0 ... #endif
to allow for nesting comments. Something like this:madjar commentedon Oct 3, 2013
From what I've gathered from the code, there are two implementations of the comment parsing, one of which supports nested comments, so I guess #9701 should be fixed before this bug.
brson commentedon Oct 15, 2013
That's pretty funny that the pretty printer already supports nested comments. I don't think they necessarily have to be merged to fix this bug, though our lexing is a bit of a mess.
brson commentedon Oct 15, 2013
@madjar Are you going to tackle this?
madjar commentedon Oct 16, 2013
@brson If there's no massive refactoring to do, I can try! Expect a PR soon.
Add support for nested comments
auto merge of #9936 : madjar/rust/master, r=alexcrichton
auto merge of #9936 : madjar/rust/master, r=alexcrichton
jibal commentedon Jun 9, 2014
The reference manual says "Comments in Rust code follow the general C++ style of line and block-comment forms, with no nesting of block-comment delimiters" ... right after production rules for nested comments.
huonw commentedon Jun 9, 2014
@jibal looks like it was forgotten to be updated, thanks for noticing! (I opened #14767.)
Auto merge of rust-lang#9469 - Alexendoo:expr-field-visitor, r=giraffate