Skip to content

[NLL] Loss of 'static relaxation suggestion under NLL #95701

@jackh726

Description

@jackh726
Member

In the src/test/ui/suggestions/impl-on-dyn-trait-with-implicit-static-bound.rs test, we give the suggestion consider relaxing the implicit `'static` requirement under migrate mode. Under NLL, we lose that suggestion, and have a slightly less user-friendly error message.

Importantly, with the suggestion, the code is rustfix-able. Without the suggestion, it is not.

Activity

added
A-diagnosticsArea: Messages for errors, warnings, and lints
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
A-NLLArea: Non-lexical lifetimes (NLL)
NLL-diagnosticsWorking towards the "diagnostic parity" goal
on Apr 5, 2022
b-naber

b-naber commented on May 19, 2022

@b-naber
Contributor

@jackh726 Is this a blocker for removing migrate mode?

jackh726

jackh726 commented on May 19, 2022

@jackh726
MemberAuthor

In my opinion, no. It's just a suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-NLLArea: Non-lexical lifetimes (NLL)A-diagnosticsArea: Messages for errors, warnings, and lintsNLL-diagnosticsWorking towards the "diagnostic parity" goalT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @jackh726@b-naber

      Issue actions

        [NLL] Loss of `'static` relaxation suggestion under NLL · Issue #95701 · rust-lang/rust