-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Description
Compiletest currently has two different arguments telling it which python to use. Since #95441, both are always the same. We should change it to just one --python
argument to simplify things.
Mentoring instructions: Change
rust/src/tools/compiletest/src/main.rs
Lines 64 to 65 in f38c5c8
.reqopt("", "lldb-python", "path to python to use for doc tests", "PATH") | |
.reqopt("", "docck-python", "path to python to use for doc tests", "PATH") |
to be a single
python
argument, then change Lines 1403 to 1405 in f38c5c8
cmd.arg("--docck-python").arg(builder.python()); | |
cmd.arg("--lldb-python").arg(builder.python()); |
@AlecGoncharow are you interested in tackling this one too? :)
@rustbot label +A-rustbuild +A-testsuite +E-easy +E-mentor
Originally posted by @jyn514 in #95441 (comment)
AlecGoncharow
Metadata
Metadata
Assignees
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
AlecGoncharow commentedon Apr 13, 2022
@rustbot claim
--*-python
args #96237Rollup merge of rust-lang#96237 - AlecGoncharow:issue-96011-fix, r=Ma…