Skip to content

Show file path on suggestions when the suggestion file differs from the main label's file #97439

Closed
@estebank

Description

@estebank
Contributor

We currently show structured suggestions without the file path because it is considered redundant output, but when the suggestion is to modify a file that isn't the local file the main diagnostic highlights, then the suggestion is confusing.

Activity

added
A-diagnosticsArea: Messages for errors, warnings, and lints
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
A-suggestion-diagnosticsArea: Suggestions generated by the compiler applied by `cargo fix`
D-confusingDiagnostics: Confusing error or lint that should be reworked.
D-papercutDiagnostics: An error or lint that needs small tweaks.
D-inconsistentDiagnostics: Inconsistency in formatting, grammar or style between diagnostic messages.
D-terseDiagnostics: An error or lint that doesn't give enough information about the problem at hand.
on May 26, 2022
compiler-errors

compiler-errors commented on Jun 21, 2022

@compiler-errors
Member

Isn't this fixed?

estebank

estebank commented on Jun 21, 2022

@estebank
ContributorAuthor

Yes, fixed by #97605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-diagnosticsArea: Messages for errors, warnings, and lintsA-suggestion-diagnosticsArea: Suggestions generated by the compiler applied by `cargo fix`D-confusingDiagnostics: Confusing error or lint that should be reworked.D-inconsistentDiagnostics: Inconsistency in formatting, grammar or style between diagnostic messages.D-papercutDiagnostics: An error or lint that needs small tweaks.D-terseDiagnostics: An error or lint that doesn't give enough information about the problem at hand.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @estebank@compiler-errors

        Issue actions

          Show file path on suggestions when the suggestion file differs from the main label's file · Issue #97439 · rust-lang/rust