Skip to content

Update all pre-cloned submodules on startup #100008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2022
Merged

Update all pre-cloned submodules on startup #100008

merged 1 commit into from
Aug 3, 2022

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Aug 1, 2022

Fixes #99083

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Aug 1, 2022
@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 1, 2022
@jyn514
Copy link
Member Author

jyn514 commented Aug 2, 2022

@bjorn3 happy to let you approve if you like - this fixes the bug you pointed out :)

@bors delegate=@bjorn3

@bors
Copy link
Collaborator

bors commented Aug 2, 2022

✌️ @bjorn3 can now approve this pull request

@bjorn3
Copy link
Member

bjorn3 commented Aug 2, 2022

./x.py check now indeed eagerly updates all submodules, but ./x.py doesn't. I also couldn't check my initial repro anymore as rust-analyzer is now a subtree instead of a submodule. In any case it doesn't seem to regress anything and the code is nicer, so

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 2, 2022

📌 Commit f2164c3 has been approved by bjorn3

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 2, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 3, 2022
@bors
Auto merge of rust-lang#100082 - matthiaskrgr:rollup-ywu4iux, r=matth…
e141246 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#99933 (parallelize HTML checking tool)
 - rust-lang#99958 (Improve position named arguments lint underline and formatting names)
 - rust-lang#100008 (Update all pre-cloned submodules on startup)
 - rust-lang#100049 (:arrow_up: rust-analyzer)
 - rust-lang#100070 (Clarify Cargo.toml comments)
 - rust-lang#100074 (rustc-docs: Be less specific about the representation of `+bundle`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4fbe53f into rust-lang:master Aug 3, 2022
@rustbot rustbot added this to the 1.64.0 milestone Aug 3, 2022
@jyn514 jyn514 deleted the eager-submodules branch February 25, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.

Bootstrap: Initialized submodules no longer eagerly updated by running x.py
6 participants
@jyn514 @rust-highfive @bors @bjorn3 @Mark-Simulacrum @rustbot