ci: Upgrade non-dist Linux testers from ubuntu:16.04 to 22.04

[cuviper]

The main goal of updating to 22.04 is to get away from llvm.allow-old-toolchain.
A side benefit is that they can also use the system cmake instead of building one.

[rust-highfive]

r? @pietroalbini

(rust-highfive has picked a reviewer for you, use r? to override)

[cuviper]

I don't know how rustdoc-gui tests work, but this seems confused:

⚠️ Installed version of browser-ui-test (`0.9.7:undefined`) is different than the one used in the CI (`0.9.7`)
You can install this version using `npm update browser-ui-test` or by using `npm install [email protected]`

[Mark-Simulacrum]

I think I've seen that locally too. You can probably adjust the code in rustbuild(?) to just be OK with a :undefined suffix.

[cuviper]

Ok, that looks like an additional field in the npm output, though always "undefined":

# npm list --parseable --long --depth=0 --global
/node-v14.4.0-linux-x64/lib::undefined
/node-v14.4.0-linux-x64/lib/node_modules/browser-ui-test:[email protected]:undefined
/node-v14.4.0-linux-x64/lib/node_modules/npm:[email protected]:undefined

I've attempted to fix that up by splitting on just ':' first.

[cuviper]

Here's the next failure:

Running 68 rustdoc-gui (16 concurrently) ...
FFERROR: puppeteer failed when trying to create a new page. Please try again with `--no-sandbox`

`browser-ui-test` crashed unexpectedly. Please try again with adding `--test-args --no-sandbox` at the end. For example: `x.py test src/test/rustdoc-gui --test-args --no-sandbox`

I can certainly add that --no-sandbox, if someone will second the suggestion as being reasonable in CI...

[Urgau]

Here's the next failure:

Running 68 rustdoc-gui (16 concurrently) ...
FFERROR: puppeteer failed when trying to create a new page. Please try again with `--no-sandbox`

`browser-ui-test` crashed unexpectedly. Please try again with adding `--test-args --no-sandbox` at the end. For example: `x.py test src/test/rustdoc-gui --test-args --no-sandbox`

I can certainly add that --no-sandbox, if someone will second the suggestion as being reasonable in CI...

cc @GuillaumeGomez (as maintainer of browser-ui-test in the rust repo)

[GuillaumeGomez]

You need to add --test-args --no-sandbox where browser-ui-test is called (so in docker/host-x86_64/x86_64-gnu-tools/Dockerfile where we call test/rustdoc-gui).

[cuviper]

Alright, thanks, I just wanted to make sure that was okay since we didn't need it before. I've added it now.

[GuillaumeGomez]

That is a new error. Sometimes the page crashes apparently O.o

[bors]

☔ The latest upstream changes (presumably #99967) made this pull request unmergeable. Please resolve the merge conflicts.

[cuviper]

Page crashed again. Would it make sense to try with newer Node.js? Looks like the current LTS is 16.17.0.

[GuillaumeGomez]

Updating nodejs is a good idea. Not sure if it will solve the issue though since it seems that chromium is the issue. You can try limiting the number of parallel jobs with --jobs (as you can see here).

[cuviper]

OK, I see puppeteer follows the maintenance LTS, which is still v14, so I only updated that to node 14.20.0 for now. But adding rustdoc-gui --jobs 1 worked locally for me to avoid the page crashes, and there aren't so many to worry about time IMO.

Longer term: AIUI the chromium version is set by puppeteer -- you might want to update that in browser-ui-test?

npm WARN deprecated [email protected]: Version no longer supported. Upgrade to @latest

[GuillaumeGomez]

The reason why I didn't update the puppeteer version is because for some unknown reason, starting the next version, you can't click on pseudo elements (so div::after for example). But I think I'll need to update it at some point because this version is just too old.

[cuviper]

@pietroalbini this should be working and ready for review now.

[cuviper]

r? @Mark-Simulacrum

[Mark-Simulacrum]

@bors r+ rollup=iffy

[bors]

📌 Commit b96cde7 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

[bors]

⌛ Testing commit b96cde7 with merge fb88811...

[bors]

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing fb88811 to master...

[rust-timer]

Finished benchmarking commit (fb88811): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	7.2%	[7.2%, 7.2%]	1
Improvements ✅ (primary)	-4.7%	[-4.7%, -4.7%]	1
Improvements ✅ (secondary)	-2.5%	[-2.6%, -2.5%]	2
All ❌✅ (primary)	-4.7%	[-4.7%, -4.7%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	2.5%	[2.0%, 3.1%]	4
Regressions ❌ (secondary)	3.3%	[3.3%, 3.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.5%	[2.0%, 3.1%]	4

Footnotes

1. the arithmetic mean of the percent change ↩ ↩²

2. number of relevant changes ↩ ↩²