Const unification is already infallible, remove the error handling logic #102128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
oli-obk
added
C-cleanup
|
yeah, idk 🤷 @bors r+ rollup |
bors
added
the
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 23, 2022
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#102113 (OpTy: fix a method taking self rather than &self) - rust-lang#102118 (rustdoc: clean up line numbers on code examples) - rust-lang#102123 (Add note to clippy::non_expressive_names doc) - rust-lang#102125 (rustdoc: remove no-op CSS `.content .item-info { position: relative }`) - rust-lang#102127 (Use appropriate variable names) - rust-lang#102128 (Const unification is already infallible, remove the error handling logic) - rust-lang#102133 (Use valtrees for comparison) - rust-lang#102135 (Improve some AllTypes fields name) - rust-lang#102144 (Extend const_convert with const {FormResidual, Try} for ControlFlow.) - rust-lang#102147 (rustdoc: remove no-op CSS `.location:empty { border: none }`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @lcnr
is this expected to be used in the future? Right now it is dead code.