rustdoc: Update doc comment for splitn_mut to include mutable in the … #102326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-libs
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thomcc (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Thanks. @bors r+ rollup |
bors
added
S-waiting-on-bors
notriddle
added a commit
to notriddle/rust
that referenced
this pull request
Sep 26, 2022
… r=thomcc rustdoc: Update doc comment for splitn_mut to include mutable in the … The doc comment for [splitn](https://github.com/rust-lang/rust/blob/master/library/core/src/slice/mod.rs#L2051:L2056) is the exact same as the comment for [splitn_mut](https://github.com/rust-lang/rust/blob/master/library/core/src/slice/mod.rs#L2079:L2084). The doc comment for `splitn_mut` should instead say it's working on a mutable subslice.
This was referenced Sep 26, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 27, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#102283 (Improve code example for Option::unwrap_or_default) - rust-lang#102319 (rustdoc: merge CSS `table` rules into `.docblock`) - rust-lang#102321 ( Rustdoc-Json: List impls for primitives) - rust-lang#102322 (Document that Display automatically implements ToString) - rust-lang#102325 (rustdoc: give `.line-number` / `.line-numbers` meaningful names) - rust-lang#102326 (rustdoc: Update doc comment for splitn_mut to include mutable in the …) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The doc comment for splitn is the exact same as the comment for splitn_mut. The doc comment for
splitn_mutshould instead say it's working on a mutable subslice.