Allow --cfg on rustpkg test #10282
Merged
Allow --cfg on rustpkg test #10282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -252,7 +252,7 @@ pub fn flags_forbidden_for_cmd(flags: &RustcFlags, | |||
| return true; | |||
| } | |||
|
|
|||
| if !cfgs.is_empty() && cmd != "build" && cmd != "install" { | |||
| if !cfgs.is_empty() && cmd != "build" && cmd != "install" && cmd != "test" { | |||
| println("The --cfg option can only be used with the build or install commands."); | |||
|
@huonw Oops, fixed |
bors
added a commit
that referenced
this pull request
Nov 5, 2013
blyxyas
pushed a commit
to blyxyas/rust
that referenced
this pull request
Jan 3, 2024
… r=blyxyas feature: add new lint `pub_underscore_fields` fixes: rust-lang#10282 This PR introduces a new lint `pub_underscore_fields` that lints when a user has marked a field of a struct as public, but also prefixed it with an underscore (`_`). This is something users should avoid because the two ideas are contradictory. Prefixing a field with an `_` is inferred as the field being unused, but making a field public infers that it will be used. - \[x] Followed [lint naming conventions][lint_naming] - I believe I followed the naming conventions, more than happy to update the naming if I did not :) - \[x] Added passing UI tests (including committed `.stderr` file) - \[x] `cargo test` passes locally - \[x] Executed `cargo dev update_lints` - \[x] Added lint documentation - \[x] Run `cargo dev fmt` --- changelog: new lint: [`pub_underscore_fields`] [rust-lang#10283](rust-lang/rust-clippy#10283) <!-- changelog_checked -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10238