Print return-position impl Trait in trait verbosely if -Zverbose
#102904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @fee1-dead (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
cjgillot
reviewed
Oct 12, 2022
| @@ -637,7 +637,9 @@ pub trait PrettyPrinter<'tcx>: | |||
| p!(print_def_path(def_id, &[])); | |||
| } | |||
| ty::Projection(ref data) => { | |||
| if self.tcx().def_kind(data.item_def_id) == DefKind::ImplTraitPlaceholder { | |||
| if self.tcx().def_kind(data.item_def_id) == DefKind::ImplTraitPlaceholder | |||
| && !(self.tcx().sess.verbose() || NO_QUERIES.with(|q| q.get())) | |||
There was a problem hiding this comment.
As def_kind is a query, should the test be reversed to short-circuit it?
Otherwise r=me.
compiler-errors
force-pushed
the
rpitit-verbosely
branch
from
9f3bf6a to
61f0973
Compare
|
@bors r=cjgillot |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 13, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#102765 (Suggest `==` to the first expr which has `ExprKind::Assign` kind) - rust-lang#102854 (openbsd: don't reallocate a guard page on the stack.) - rust-lang#102904 (Print return-position `impl Trait` in trait verbosely if `-Zverbose`) - rust-lang#102947 (Sort elaborated existential predicates in `object_ty_for_trait`) - rust-lang#102956 (Use `full_res` instead of `expect_full_res`) - rust-lang#102999 (Delay `is_intrinsic` query until after we've determined the callee is a function) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the behavior a bit closer to regular
impl Traitprinting