Don't use periods in target names #104523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
They can cause issues in e.g. cargo.
flba-eb
force-pushed
the
fix_nto_target_name
branch
from
99a4701 to
5dd073e
Compare
rustbot
added
the
A-testsuite
|
CC @ehuss |
|
CI output (excerpt) of 5dd073e, before fixing the issue: |
|
CC @gh-tr |
|
@wesleywiser and @ehuss , I think this PR is ready for review from your side (especially the test and change/addition in tier 3 policy). |
wesleywiser
approved these changes
Nov 23, 2022
flba-eb
changed the title
|
These commits modify compiler targets. |
|
Issue was discussed with @gh-tr and the QNX/Neutrino parts have been approved by him. |
|
Confirming. Change makes sense. |
wesleywiser
approved these changes
Nov 28, 2022
|
@bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 29, 2022
…leywiser Don't use periods in target names Using a period in the target name can cause issues in e.g. cargo, see also https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Running.20tests.20on.20remote.20target
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 30, 2022
…iaskrgr Rollup of 14 pull requests Successful merges: - rust-lang#103876 (type alias impl trait: add tests showing that hidden type only outlives lifetimes that occur in bounds) - rust-lang#104427 (Explain why `rematch_impl` fails to be infallible) - rust-lang#104436 (Add slice to the stack allocated string comment) - rust-lang#104523 (Don't use periods in target names) - rust-lang#104627 (Print all features with --print target-features) - rust-lang#104911 (Make inferred_outlives_crate return Clause) - rust-lang#105002 (Add `PathBuf::as_mut_os_string` and `Path::as_mut_os_str`) - rust-lang#105023 (Statics used in reachable function's inline asm are reachable) - rust-lang#105045 (`rustc_ast_{passes,pretty}`: remove `ref` patterns) - rust-lang#105049 (Hermit: Minor build fixes) - rust-lang#105051 (Replace a macro with a function) - rust-lang#105062 (rustdoc: use shorthand background for rustdoc toggle CSS) - rust-lang#105066 (move `candidate_from_obligation` out of assembly) - rust-lang#105068 (Run patchelf also on rust-analyzer-proc-macro-srv.) Failed merges: - rust-lang#105050 (Remove useless borrows and derefs) r? `@ghost` `@rustbot` modify labels: rollup
flba-eb
added a commit
to flba-eb/ctest2
that referenced
this pull request
Dec 6, 2022
flba-eb
added a commit
to flba-eb/ctest2
that referenced
this pull request
Dec 6, 2022
workingjubilee
added
the
O-neutrino
tgross35
pushed a commit
to tgross35/ctest2
that referenced
this pull request
Apr 2, 2025
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Apr 2, 2025
tgross35
pushed a commit
to tgross35/ctest2
that referenced
this pull request
Apr 2, 2025
sanstzu
pushed a commit
to sanstzu/rust-libc
that referenced
this pull request
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a period in the target name can cause issues in e.g. cargo, see also https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Running.20tests.20on.20remote.20target