Skip to content

Fix ICE from #105101 #105106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2022
Merged

Fix ICE from #105101 #105106

merged 1 commit into from
Dec 1, 2022

Conversation

jhpratt
Copy link
Member

@jhpratt jhpratt commented Nov 30, 2022 •
edited
Loading

Fixes #105101

Rather than comparing idents, compare spans, which should be unique to each variant.

@rustbot
Copy link
Collaborator

rustbot commented Nov 30, 2022

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 30, 2022
@jhpratt jhpratt mentioned this pull request Nov 30, 2022
Closed
@TaKO8Ki
Copy link
Member

TaKO8Ki commented Dec 1, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 1, 2022

📌 Commit ab264ae has been approved by TaKO8Ki

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 1, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 1, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 1, 2022
@matthiaskrgr
Rollup merge of rust-lang#105106 - jhpratt:issue-105101, r=TaKO8Ki
8bfd00d 
Fix ICE from rust-lang#105101

Fixes rust-lang#105101

Rather than comparing idents, compare spans, which should be unique to each variant.
@Dylan-DPC Dylan-DPC mentioned this pull request Dec 1, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Dec 1, 2022
@Dylan-DPC
Rollup merge of rust-lang#105106 - jhpratt:issue-105101, r=TaKO8Ki
e318732 
Fix ICE from rust-lang#105101

Fixes rust-lang#105101

Rather than comparing idents, compare spans, which should be unique to each variant.
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 1, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 1, 2022
@bors
Auto merge of rust-lang#105125 - matthiaskrgr:rollup-fr0snmj, r=matth…
c090c68 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#105078 (Fix `expr_to_spanned_string` ICE)
 - rust-lang#105087 (Extract llvm datalayout parsing out of spec module)
 - rust-lang#105088 (rustdoc: remove redundant CSS `div.desc { display: block }`)
 - rust-lang#105106 (Fix ICE from rust-lang#105101)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ee9eaa6 into rust-lang:master Dec 1, 2022
@rustbot rustbot added this to the 1.67.0 milestone Dec 1, 2022
@jhpratt jhpratt deleted the issue-105101 branch December 1, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-lang Relevant to the language team
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

ICE with #[derive(Default)] on enum with repeated variant names
5 participants
@jhpratt @rustbot @TaKO8Ki @bors @petrochenkov