Skip to content

Cheaper dump_mir take two #105121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 4, 2022
Merged

Cheaper dump_mir take two #105121

merged 5 commits into from
Dec 4, 2022

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Dec 1, 2022

alternative to #105083

r? @nnethercote

@rustbot
Copy link
Collaborator

rustbot commented Dec 1, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nnethercote (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 1, 2022
@oli-obk
Copy link
Contributor Author

oli-obk commented Dec 1, 2022

@bors try @rust-timer queue

@rustbot
Copy link
Collaborator

rustbot commented Dec 1, 2022

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 1, 2022
@bors
Copy link
Collaborator

bors commented Dec 1, 2022

⌛ Trying commit 4f593ce with merge 6c723345f487c609556aff72ff9696832309a002...

@oli-obk oli-obk mentioned this pull request Dec 1, 2022
Closed
@bors
Copy link
Collaborator

bors commented Dec 1, 2022

☀️ Try build successful - checks-actions
Build commit: 6c723345f487c609556aff72ff9696832309a002 (6c723345f487c609556aff72ff9696832309a002)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6c723345f487c609556aff72ff9696832309a002): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.0% [-1.9%, -0.5%] 17
Improvements ✅
(secondary)		 -1.4% [-2.0%, -0.5%] 9
All ❌✅ (primary) -1.0% [-1.9%, -0.5%] 17

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.6% [-0.6%, -0.6%] 1
Improvements ✅
(secondary)		 -2.6% [-2.6%, -2.6%] 1
All ❌✅ (primary) -0.6% [-0.6%, -0.6%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.8% [1.8%, 1.8%] 1
Regressions ❌
(secondary)		 2.1% [2.1%, 2.1%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.8% [1.8%, 1.8%] 1

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 1, 2022
nnethercote
nnethercote reviewed Dec 1, 2022
View reviewed changes
compiler/rustc_middle/src/mir/mod.rs Outdated
@@ -184,30 +184,7 @@ impl RuntimePhase {

impl Display for MirPhase {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this impl?

nnethercote
nnethercote reviewed Dec 1, 2022
View reviewed changes
nnethercote
nnethercote reviewed Dec 1, 2022
View reviewed changes
@nnethercote
Copy link
Contributor

Looks good except for the question about the 000 above. I'll give you bonus points if you also rename dump_mir as maybe_dump_mir, which is a better name IMO for a function that usually doesn't dump MIR.

@oli-obk oli-obk force-pushed the simpler-cheaper-dump_mir branch from 9a92e44 to c7e94b0 Compare December 2, 2022 15:55
@oli-obk
Copy link
Contributor Author

oli-obk commented Dec 2, 2022

@JakobDegen I think we talked about pass_count values in a previous PR. Can you have a look at c7e94b0?

@nnethercote
Copy link
Contributor

r=me if @JakobDegen is happy with the pass_count.

@JakobDegen
Copy link
Contributor

This change lgtm. I actually don't quite like the output of this right now, but that's not a result of changes by this PR. I'll wait for this to merge and then try and make some improvements in a follow-up.

@nnethercote
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 4, 2022

📌 Commit c7e94b0 has been approved by nnethercote

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 4, 2022
@bors
Copy link
Collaborator

bors commented Dec 4, 2022

⌛ Testing commit c7e94b0 with merge fd02567...

@bors
Copy link
Collaborator

bors commented Dec 4, 2022

☀️ Test successful - checks-actions
Approved by: nnethercote
Pushing fd02567 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 4, 2022
@bors bors merged commit fd02567 into rust-lang:master Dec 4, 2022
@rustbot rustbot added this to the 1.67.0 milestone Dec 4, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (fd02567): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.9% [0.9%, 0.9%] 1
Improvements ✅
(primary)		 -1.1% [-1.9%, -0.6%] 17
Improvements ✅
(secondary)		 -1.4% [-1.9%, -0.6%] 9
All ❌✅ (primary) -1.1% [-1.9%, -0.6%] 17

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.7% [-2.6%, -0.8%] 2
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#105121 - oli-obk:simpler-cheaper-dump_mir, r=…
f07c233 
…nnethercote

Cheaper `dump_mir` take two

alternative to rust-lang#105083

r? `@nnethercote`
@oli-obk oli-obk deleted the simpler-cheaper-dump_mir branch March 24, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnethercote nnethercote nnethercote left review comments

Assignees

@nnethercote nnethercote

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
6 participants
@oli-obk @rustbot @rust-timer @bors @nnethercote @JakobDegen