Skip to content

Don't add a note for implementing a trait if its inner type is erroneous #105181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2022
Merged

Don't add a note for implementing a trait if its inner type is erroneous #105181

merged 1 commit into from
Dec 3, 2022

Conversation

bhbs
Copy link
Contributor

@bhbs bhbs commented Dec 2, 2022

Fix #105138

@rustbot
Copy link
Collaborator

rustbot commented Dec 2, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 2, 2022
bhbs
bhbs commented Dec 2, 2022
View reviewed changes
compiler-errors
compiler-errors reviewed Dec 2, 2022
View reviewed changes
@bhbs bhbs requested a review from compiler-errors December 3, 2022 00:10
@estebank
Copy link
Contributor

estebank commented Dec 3, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 3, 2022

📌 Commit 715d4a8 has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 3, 2022
@JohnTitor JohnTitor mentioned this pull request Dec 3, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 3, 2022
@bors
Auto merge of rust-lang#105196 - JohnTitor:rollup-8rxqnq6, r=JohnTitor
24f2704 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#104903 (Use ocx.normalize in report_projection_error)
 - rust-lang#105032 (improve doc of into_boxed_slice and impl From<Vec<T>> for Box<[T]>)
 - rust-lang#105100 (Add missing intra-doc link)
 - rust-lang#105181 (Don't add a note for implementing a trait if its inner type is erroneous)
 - rust-lang#105182 (Rustdoc-Json: Don't inline foreign traits)
 - rust-lang#105188 (Don't elide type information when printing E0308 with `-Zverbose`)
 - rust-lang#105189 (rustdoc: clean up redundant CSS on `.rustdoc-toggle.hideme`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8f36866 into rust-lang:master Dec 3, 2022
@rustbot rustbot added this to the 1.67.0 milestone Dec 3, 2022
@bhbs bhbs deleted the skip-note branch December 3, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors Awaiting requested review from compiler-errors

Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

Into<[type error]> in diagnostic
5 participants
@bhbs @rustbot @estebank @bors @compiler-errors