Skip to content

Conversation

cjgillot
Copy link
Contributor

Fixes #105538

@rustbot
Copy link
Collaborator

rustbot commented Dec 25, 2022

r? @eholk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 25, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 25, 2022

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rust-log-analyzer

This comment has been minimized.

@cjgillot cjgillot force-pushed the mir-inline-location branch from 9080b4c to edc73f9 Compare December 25, 2022 18:48
@eholk
Copy link
Contributor

eholk commented Dec 27, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 27, 2022

📌 Commit edc73f9 has been approved by eholk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2022
@bors
Copy link
Collaborator

bors commented Dec 29, 2022

⌛ Testing commit edc73f9 with merge 11a338a...

@bors
Copy link
Collaborator

bors commented Dec 29, 2022

☀️ Test successful - checks-actions
Approved by: eholk
Pushing 11a338a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 29, 2022
@bors bors merged commit 11a338a into rust-lang:master Dec 29, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 29, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (11a338a): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.4% [-1.4%, -1.4%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.2% [2.1%, 2.2%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
Give the correct track-caller location with MIR inlining.

Fixes rust-lang#105538
@cjgillot cjgillot deleted the mir-inline-location branch January 7, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MIR inlining breaks Location::caller()
6 participants