Use more consistent progress messages in bootstrap #106303
Merged
+67
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, clean only supported `--stage 0` for specific crates.
The new `crate_description` function generates a string that looks
like
```
: {rustc_query_impl}
```
rustbot
added
T-bootstrap
Mark-Simulacrum
approved these changes
Dec 30, 2022
| descr.push_str(", "); | ||
| descr.push_str(krate.as_ref()); | ||
| } | ||
| descr.push('}'); |
There was a problem hiding this comment.
FWIW, this seems like it could be near-identically replicated with https://doc.rust-lang.org/nightly/std/fmt/struct.DebugSet.html, at the cost of {"rustc_interface"} rather than {rustc_interface}.
But 🤷 either way -- the implementation is pretty simple.
There was a problem hiding this comment.
all the fmt::Debug* types only work inside a fmt::Debug impl unfortunately, since we need access to a fmt::Formatter 😞 and at that point it doesn't make the code much shorter.
jyn514
added
S-blocked
Before:
```
Testing ["rustc_interface"] stage0 (aarch64-unknown-linux-gnu -> aarch64-unknown-linux-gnu)
```
After:
```
Testing {rustc_interface} stage0 (aarch64-unknown-linux-gnu -> aarch64-unknown-linux-gnu)
```
Note there is a slight consistency between `build` and `test`: The
former doesn't print "compiler artifacts". It would be annoying to fix
and doesn't hurt anything, so I left it be.
```
; x t rustc_interface --stage 0 --dry-run
Testing {rustc_interface} stage0 (aarch64-unknown-linux-gnu -> aarch64-unknown-linux-gnu)
; x b rustc_interface --stage 0 --dry-run
Building {rustc_interface} stage0 compiler artifacts (aarch64-unknown-linux-gnu -> aarch64-unknown-linux-gnu)
```
rust-cloud-vms
bot
force-pushed
the
consistent-progress
branch
from
49773d3 to
c8c849e
Compare
bors
added
S-waiting-on-bors
bors
added
S-waiting-on-author
jyn514
added a commit
to jyn514/rust
that referenced
this pull request
Dec 30, 2022
bootstrap: Get rid of tail_args in stream_cargo Based on rust-lang#106303 for convenience. r? `@Mark-Simulacrum`
jyn514
added a commit
to jyn514/rust
that referenced
this pull request
Dec 31, 2022
bootstrap: Get rid of tail_args in stream_cargo Based on rust-lang#106303 for convenience. r? ``@Mark-Simulacrum``
jyn514
added a commit
to jyn514/rust
that referenced
this pull request
Dec 31, 2022
bootstrap: Get rid of tail_args in stream_cargo Based on rust-lang#106303 for convenience. r? ```@Mark-Simulacrum```
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Dec 31, 2022
bootstrap: Get rid of tail_args in stream_cargo Based on rust-lang#106303 for convenience. r? ````@Mark-Simulacrum````
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #106271 for convenience, but I can make it independent if you like.
This makes
testlook the same asclean.Before:
After:
Note there is a slight consistency between
buildandtest: Theformer doesn't print "compiler artifacts". It would be annoying to fix
and doesn't hurt anything, so I left it be.
r? @Mark-Simulacrum