Skip to content

coop-rs 03 vec macroed #107607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 112 commits into from
Closed

coop-rs 03 vec macroed #107607

wants to merge 112 commits into from

Conversation

peter-lyons-kehl
Copy link
Contributor

Work in progress.
Separated: Coallocation for Vec + VecDeque (+ RawVec) only.
Applicable to any allocator, not just Global.

r? peter-kehl

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 2, 2023
@peter-lyons-kehl
Copy link
Contributor Author

Instead of #107274.

@Noratrieb Noratrieb added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2023
@peter-lyons-kehl
START CoAlloc API
cfe596b
@peter-lyons-kehl
CoAlloc: RawVec + compiler 'tests'
68e9405
@peter-lyons-kehl
CoAlloc: GlobalAlloc API
238f291
@peter-lyons-kehl
CoAlloc: Alloc API
f4aa6f2
@peter-lyons-kehl
CoAlloc: RawVec includes GlobalCoAllocMeta based on allocator; relate…
90dab29 
…d bounds - NOT COMPILING (no ICE, but standard compiler error)
@peter-lyons-kehl
CoAlloc: VecDeque (PROBABLY NOT COMPILING, standard error)
f067d64
@peter-lyons-kehl
CoAlloc: RawVec + Vec with COOP_PREFERRED. PROBABLY NOT COMPILING, bu…
1dfcc39 
…t no ICE.
@peter-lyons-kehl
VecDeque with COOP_PREFERRED. PROBABLY NOT COMPILING, but no ICE.
c8f25a8
@peter-lyons-kehl
CoAlloc: RawVec, Vec, Box uses bounds. ICE
14c624b
@peter-lyons-kehl
CoAlloc: BinaryHeap now uses bounds. (Probably needs to go together w…
594149d 
…ith Vec). ICE
@peter-lyons-kehl
CoAlloc: VecDeque now uses bounds. ICE
b19d9e8
@peter-lyons-kehl
CoAlloc: VecDeque. Probably ICE.
e8f516b
@peter-lyons-kehl
CoAlloc: Vec + Slice. ICE
02719eb
@peter-lyons-kehl
CoAlloc: VecDeque. ICE
442f68d
@peter-lyons-kehl
CoAlloc: Minor
979ea25
@peter-lyons-kehl
CoAlloc: Vec + its use cases. ICE
57f9939
@peter-lyons-kehl
CoAlloc: VecDeque minor. ICE
7b74fbc
@peter-lyons-kehl
CoAlloc: Vec, Alloc, GlobalAlloc: x test tidy --bless. ICE
7943a12
@peter-lyons-kehl
CoAlloc: VecDeque + BinaryHeap: x test tidy --bless. ICE
47d2659
@peter-lyons-kehl
CoAlloc: VecDeque. ICE
d5b92f5
@peter-lyons-kehl
CoAlloc: minor tidy
13190c4
@peter-lyons-kehl
CoAlloc: Preference/config types in ::alloc::co_alloc. Config value m…
687a318 
…acros + transformation macros in ::alloc. WIP (won't compile).
@peter-lyons-kehl
CoAlloc: Renaming to use new value/config + transformation macros.
0f5e8b0
@peter-lyons-kehl
CoAlloc: Using config + transformation macros in ::alloc. ICE!
eb0bc33
@peter-lyons-kehl
CoAlloc: co_alloc_pref changed to 0usize - and (at least now) no ICE.
b243399
@peter-lyons-kehl
CoAlloc: library/alloc now uses macros, and no ICE. But meta_num_slot…
84f494d 
…s macro is hardcoded - TO FIX.
@peter-lyons-kehl
CoAlloc: Using macros for config + transformations. WIP
611da39
@peter-lyons-kehl
CoAlloc: (Some) Separation of co-alloc-aware traits & methods.
10b3593
@peter-lyons-kehl
CoAlloc: Undoing generalizations + splitting. WIP
3cae616
@peter-lyons-kehl
CoAlloc: slice::to_vec_co, slice::to_vec_in_co.
5e0d7df
@peter-lyons-kehl
CoAlloc: Separated Vec::from_raw_parts_co and similar (and also in Ve…
5a1f3bd 
…cDeque). Mostly compiling.
@peter-lyons-kehl
CoAlloc: tidy
023f14a
@peter-lyons-kehl
CoAlloc: Fixed my buggy rebase. Added slice::SpecCloneIntoVecCo and f…
a56b09a 
…ixed Vec::clone_from.
@peter-lyons-kehl
CoAlloc: Default for Vec - both coallocation-aware (default fn), and …
c2eea98 
…'standard'.
@peter-lyons-kehl
CoAlloc: VecDeque: new_co, with_capacity_co, made default() coallocat…
89e6170 
…ion-friendly.
@peter-lyons-kehl
CoAlloc: tidy
4822feb
@peter-lyons-kehl
CoAlloc: Fixed previous sick result of: tidy --bless
fae59a0
@peter-lyons-kehl
CoAlloc: slice::into_vec_co - for vec![...].
4821cb2
@peter-lyons-kehl
CoAlloc: compiler/rustc_arena: specialization; using Allocator::CoAll…
c427cd4 
…ocMeta in rustc validations.
@bors
Copy link
Collaborator

bors commented Feb 3, 2023

☔ The latest upstream changes (presumably #107642) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@peter-lyons-kehl peter-lyons-kehl mentioned this pull request Feb 17, 2023
Closed
@peter-lyons-kehl
Copy link
Contributor Author

Replaced with #108150.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@peter-lyons-kehl peter-lyons-kehl

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@peter-lyons-kehl @bors @rust-log-analyzer @rustbot @Noratrieb