Skip to content

Conversation

chriswailes
Copy link
Contributor

In #101783 I accidentally removed a load-bearing linker argument. This PR adds it back in.

r? jyn514

In rust-lang#101783 I accidentally removed
a load-bearing linker argument.  This PR adds it back in.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 3, 2023
@chriswailes
Copy link
Contributor Author

It appears that the RUSTFLAG and LD_<triple> values have different consumers and thus we should specify both.

@jyn514
Copy link
Member

jyn514 commented Feb 3, 2023

I don't have time for reviews right now.

r? bootstrap

@rustbot rustbot assigned albertlarsan68 and unassigned jyn514 Feb 3, 2023
@jyn514
Copy link
Member

jyn514 commented Feb 3, 2023

cc @albertlarsan68

@albertlarsan68
Copy link
Member

Thanks!
@bors r+

@bors
Copy link
Collaborator

bors commented Feb 4, 2023

📌 Commit 134a5ae has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2023
@bors
Copy link
Collaborator

bors commented Feb 4, 2023

⌛ Testing commit 134a5ae with merge 4aa6afa...

@bors
Copy link
Collaborator

bors commented Feb 4, 2023

☀️ Test successful - checks-actions
Approved by: albertlarsan68
Pushing 4aa6afa to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 4, 2023
@bors bors merged commit 4aa6afa into rust-lang:master Feb 4, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 4, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4aa6afa): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.4% [3.0%, 3.8%] 2
Regressions ❌
(secondary)
3.0% [1.2%, 6.5%] 21
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.4% [3.0%, 3.8%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.4% [2.1%, 2.6%] 2
Improvements ✅
(primary)
-1.0% [-1.0%, -0.9%] 2
Improvements ✅
(secondary)
-1.6% [-1.7%, -1.5%] 4
All ❌✅ (primary) -1.0% [-1.0%, -0.9%] 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants