Introduce `ReError` #107652

estebank · 2023-02-03T23:23:42Z

estebank · 2023-02-03T23:24:53Z

tests/ui/lifetimes/issue-69314.stderr

+error[E0597]: `buf` does not live long enough
+  --> $DIR/issue-69314.rs:14:19
+   |
+LL |         let m2 = &buf[..];
+   |                   ^^^ borrowed value does not live long enough
+LL |         let m = Self::g(m2).await;
+   |                 ----------- argument requires that `buf` is borrowed for `'static`
+LL |         Self::f2(m).await;
+LL |     }
+   |     - `buf` dropped here while still borrowed


We want to hide this error

I've looked at this and it seems that Self::f2 doesn't seem to get around to influencing the lifetime requirements from Self::g, let's follow up on this in a subsequent PR.

compiler/rustc_borrowck/src/universal_regions.rs

compiler-errors · 2023-02-03T23:57:51Z

cc @rust-lang/types who might have opinions about this approach.

I think making ReError should require delaying a bug or providing a ErrorGuaranteed like the error ty kind, and it should store it in the variant (ErrorGuaranteed is a zst iirc, so it shouldn't have any overhead). Then we can just ignore it during type relations, instead of delaying a bug there.

compiler/rustc_hir_analysis/src/collect/type_of.rs

compiler/rustc_infer/src/infer/lexical_region_resolve/mod.rs

oli-obk

we may want to make FlagComputation::add_region also set the error flag for error regions, but that may cause additional diagnostics changes, so maybe do it in a follow up PR

compiler/rustc_hir_analysis/src/astconv/mod.rs

compiler/rustc_infer/src/infer/lexical_region_resolve/mod.rs

oli-obk · 2023-02-08T19:59:17Z

compiler/rustc_infer/src/infer/lexical_region_resolve/mod.rs

-                VarValue::ErrorValue => tcx.lifetimes.re_static,
+                VarValue::ErrorValue => tcx.re_error(),


we may want to carry an ErrorGuaranteed through ErrorValue in the future, doesn't have to be this PR tho

I started doing this and realized that where we construct the ErrorValue we don't have easy access to ErrorGuaranteed, so I'll leave this as follow up work, as suggested.

compiler/rustc_middle/src/ty/context.rs

compiler/rustc_middle/src/ty/opaque_types.rs

oli-obk · 2023-02-08T20:03:41Z

r? @oli-obk

CC rust-lang#69314

oli-obk · 2023-02-09T11:04:09Z

@bors r+

bors · 2023-02-09T11:04:11Z

📌 Commit 3689295 has been approved by oli-obk

It is now in the queue for this repository.

bors · 2023-02-10T10:10:15Z

⌛ Testing commit 3689295 with merge d1ac43a...

bors · 2023-02-10T13:44:53Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing d1ac43a to master...

rust-timer · 2023-02-10T15:04:04Z

Finished benchmarking commit (d1ac43a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.3%	[4.3%, 4.3%]	1
Regressions ❌ (secondary)	3.1%	[2.4%, 3.8%]	12
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	4.3%	[4.3%, 4.3%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.1%	[3.1%, 3.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.1%	[3.1%, 3.1%]	1

rustbot assigned nagisa Feb 3, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 3, 2023

estebank commented Feb 3, 2023

View reviewed changes

compiler/rustc_borrowck/src/universal_regions.rs Outdated Show resolved Hide resolved

estebank force-pushed the re_error branch from 5724558 to f339e8a Compare February 3, 2023 23:34

oli-obk requested changes Feb 4, 2023

View reviewed changes

compiler/rustc_hir_analysis/src/collect/type_of.rs Outdated Show resolved Hide resolved

compiler/rustc_infer/src/infer/lexical_region_resolve/mod.rs Outdated Show resolved Hide resolved

estebank mentioned this pull request Feb 6, 2023

Add display of lifetime of Ref in fn fmt() for TypeError #107475

Closed

estebank force-pushed the re_error branch 3 times, most recently from ef4d70f to 349156e Compare February 7, 2023 16:20

oli-obk requested changes Feb 8, 2023

View reviewed changes

rustbot assigned oli-obk and unassigned nagisa Feb 8, 2023

estebank added 6 commits February 9, 2023 10:26

Introduce ReError

30cf7a3

CC rust-lang#69314

review comments

ffaf2a5

Change to ReError(ErrorGuaranteed)

861f451

Use 'static RegionVid for ReError

ed8651c

Fix RegionKind: PartialEq to account for ReError

3222725

Use ErrorGuaranteed more in ReError

3689295

estebank force-pushed the re_error branch from 349156e to 3689295 Compare February 9, 2023 10:38

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 10, 2023

bors merged commit d1ac43a into rust-lang:master Feb 10, 2023

rustbot added this to the 1.69.0 milestone Feb 10, 2023

bors mentioned this pull request Feb 10, 2023

Require TAITs to appear in the signature of items that register a hidden type #107809

Closed

estebank deleted the re_error branch November 9, 2023 05:11

matthiaskrgr mentioned this pull request Apr 20, 2024

ICE: expected principal trait object #124092

Closed

matthiaskrgr mentioned this pull request May 6, 2024

ICE: used byval ABI for unsized layout #124806

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce `ReError` #107652

Introduce `ReError` #107652

estebank commented Feb 3, 2023

estebank Feb 3, 2023

estebank Feb 6, 2023

compiler-errors commented Feb 3, 2023 •

edited

Loading

oli-obk left a comment

oli-obk Feb 8, 2023

estebank Feb 9, 2023

oli-obk commented Feb 8, 2023

oli-obk commented Feb 9, 2023

bors commented Feb 9, 2023

bors commented Feb 10, 2023

bors commented Feb 10, 2023

rust-timer commented Feb 10, 2023

		VarValue::ErrorValue => tcx.lifetimes.re_static,
		VarValue::ErrorValue => tcx.re_error(),

Introduce ReError #107652

Introduce ReError #107652

Conversation

estebank commented Feb 3, 2023

estebank Feb 3, 2023

Choose a reason for hiding this comment

estebank Feb 6, 2023

Choose a reason for hiding this comment

compiler-errors commented Feb 3, 2023 • edited Loading

oli-obk left a comment

Choose a reason for hiding this comment

oli-obk Feb 8, 2023

Choose a reason for hiding this comment

estebank Feb 9, 2023

Choose a reason for hiding this comment

oli-obk commented Feb 8, 2023

oli-obk commented Feb 9, 2023

bors commented Feb 9, 2023

bors commented Feb 10, 2023

bors commented Feb 10, 2023

rust-timer commented Feb 10, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Introduce `ReError` #107652

Introduce `ReError` #107652

compiler-errors commented Feb 3, 2023 •

edited

Loading