Add Imenu support for rust-mode. #10797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pradeep90
commented
Dec 4, 2013
pradeep90
commented
- Delete trailing whitespace.
|
Hmm, I thought *.rc was the extension used in the early days of Rust? |
|
Oh! I guess you're right... Servo has a lot of .rc files and I thought rust-mode didn't support that. I'll remove that. |
+ Delete trailing whitespace.
|
Well, if you look at the vim syntax file it's still supporting .rc but since it looks to be deprecated I think it's good to not add it. |
|
@adridu59 I have removed the support for rc from my pull request |
|
Thanks, @pradeep90 ✨ |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 2, 2023
Improve pattern printing for manual_let_else * Address a formatting issue pointed out in https://github.com/rust-lang/rust-clippy/pull/10175/files#r1137091002 * Replace variables inside | patterns in the if let: `let v = if let V::A(v) | V::B(v) = v { v } else ...` * Support nested patterns: `let v = if let Ok(Ok(Ok(v))) = v { v } else ...` * Support tuple structs with more than one arg: `let v = V::W(v, _) = v { v } else ...`; note that more than one *capture* is still not supported, so it bails for `let (v, w) = if let E::F(vi, wi) = x { (vi, wi)}` * Correctly handle .. in tuple struct patterns: `let v = V::X(v, ..) = v { v } else ...` - \[ ] Followed [lint naming conventions][lint_naming] - \[x] Added passing UI tests (including committed `.stderr` file) - \[x] `cargo test` passes locally - \[ ] Executed `cargo dev update_lints` - \[ ] Added lint documentation - \[x] Run `cargo dev fmt` [lint_naming]: https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints --- changelog: [`manual_let_else`]: improve variable name in suggestions Closes rust-lang#10431 as this PR is adding a test for the `mut` case.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 30, 2023
…shearth manual_let_else: support struct patterns This adds upon the improvements of rust-lang#10797 and: * Only prints `()` around `Or` patterns at the top level (fixing a regression of rust-lang#10797) * Supports multi-binding patterns: `let (u, v) = if let (Some(u_i), Ok(v_i)) = ex { (u_i, v_i) } else ...` * Traverses through tuple patterns: `let v = if let (Some(v), None) = ex { v } else ...` * Supports struct patterns: `let v = if let S { v, w, } = ex { (v, w) } else ...` ``` changelog: [`manual_let_else`]: improve pattern printing to support struct patterns ``` fixes rust-lang#10708 fixes rust-lang#10424
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.