rewrite of shootout-reverse-complement.rs #10799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // reverse complement | ||
| let mut seq = seq; | ||
| loop { | ||
| if seq.len() <= 1 {break;} |
There was a problem hiding this comment.
Why not while seq.len() > 1 { ... }?
|
@huonw what do you think? |
| if ch == 0 { | ||
| break; | ||
| // reverse complement | ||
| let mut it = seq.mut_iter(); |
There was a problem hiding this comment.
I'm curious, but couldn't this whole loop be replaced with seq.reverse()?
There was a problem hiding this comment.
It's reversing and transforming using complements
Equivalent but slower:
let mut it = seq.mut_iter();
loop {
match (it.next(), it.next_back()) {
(Some(front), Some(back)) => {
std::util::swap(front, back);
*front = complements[*front];
*back = complements[*back];
}
_ => break // vector exhausted.
}
}Equivalent but much slower:
seq.reverse();
for c in seq.mut_iter() {
*c = complements[*c]
}There was a problem hiding this comment.
Aha! I can totally read code.
|
Could you rebase these two commits into one? Other than that looks good to me! |
This version is inspired by the best version in C by Mr Ledrug, but without the parallelisation.
|
@alexcrichton squashed. |
bors
added a commit
that referenced
this pull request
Dec 5, 2013
…ected, r=alexcrichton This version is inspired by the best version in C by Mr Ledrug, but without the parallelisation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version is inspired by the best version in C by Mr Ledrug,
but without the parallelisation.