Skip to content

rustc_expand: make proc-macro derive error translatable #108727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2023
Merged

rustc_expand: make proc-macro derive error translatable #108727

merged 1 commit into from
Mar 4, 2023

Conversation

tshepang
Copy link
Member

@tshepang tshepang commented Mar 4, 2023 •
edited
Loading

kept this tiny so as to point to it as an example in rustc-dev-guide

@rustbot label +A-translation

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic labels Mar 4, 2023
@tshepang
Copy link
Member Author

tshepang commented Mar 4, 2023

r? rust-lang/diagnostics

@rustbot rustbot assigned davidtwco and unassigned oli-obk Mar 4, 2023
@Noratrieb
Copy link
Member

r? Nilstrieb
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 4, 2023

📌 Commit 7fe4f07 has been approved by Nilstrieb

It is now in the queue for this repository.

@rustbot rustbot assigned Noratrieb and unassigned davidtwco Mar 4, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2023
@Dylan-DPC Dylan-DPC mentioned this pull request Mar 4, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 4, 2023
@bors
Auto merge of rust-lang#108732 - Dylan-DPC:rollup-dy1l8sx, r=Dylan-DPC
276b75a 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#108298 (Fix ICE: check if snippet is `)`)
 - rust-lang#108405 (Lazily compute crate name for consider_optimizing)
 - rust-lang#108656 (Rustdoc search: Emit an error for unclosed generic)
 - rust-lang#108660 (Remove ne implementations from strings)
 - rust-lang#108669 (Allow checking whether a type allows being uninitialized)
 - rust-lang#108727 (rustc_expand: make proc-macro derive error translatable)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0965c7e into rust-lang:master Mar 4, 2023
@rustbot rustbot added this to the 1.69.0 milestone Mar 4, 2023
@tshepang tshepang deleted the example-translatable-diagnostic branch March 5, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Noratrieb Noratrieb

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
6 participants
@tshepang @Noratrieb @bors @oli-obk @davidtwco @rustbot