Skip to content

Only create graphviz nodes for reachable MIR bb's #109847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2023
Merged

Only create graphviz nodes for reachable MIR bb's #109847

merged 1 commit into from
Apr 5, 2023

Conversation

clubby789
Copy link
Contributor

Fixes #109832

@rustbot
Copy link
Collaborator

rustbot commented Apr 1, 2023

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 1, 2023
@b-naber
Copy link
Contributor

b-naber commented Apr 2, 2023

Not completely sure whether it's ok to not display them anymore.

r? @oli-obk

@rustbot rustbot assigned oli-obk and unassigned b-naber Apr 2, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Apr 5, 2023

It's fine. We usually strip unreachable blocks quickly, but requiring it on every mir transform would be a much bigger change with unclear benefit.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 5, 2023

📌 Commit 47ae42e has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2023
@JohnTitor JohnTitor mentioned this pull request Apr 5, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 5, 2023
@bors
Auto merge of rust-lang#109966 - JohnTitor:rollup-eoqjr5j, r=JohnTitor
4cb92cc 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#107236 (Add T-bootstrap label to tools)
 - rust-lang#109847 (Only create graphviz nodes for reachable MIR bb's)
 - rust-lang#109848 (submodule detection for proper fix on rust-lang#96188)
 - rust-lang#109932 (Source code scrollbar)
 - rust-lang#109952 (Move comment about python2 closer to the place it's used)
 - rust-lang#109956 (Tweak debug outputs to make debugging new solver easier)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4e0662c into rust-lang:master Apr 5, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 5, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.

ICE: self.reachable_blocks.contains on valid code with -Zdump-mir-dataflow and macros
5 participants
@clubby789 @rustbot @b-naber @oli-obk @bors