Skip to content

Conversation

clubby789
Copy link
Contributor

cc #100717

This is a couple of days work, but I decided to stop for now before the PR becomes too big. There's around 50 unresolved failures when rustc::untranslatable_diagnostic is denied, which I'll finish addressing once this PR goes thtough

A couple of outputs have changed, but in all instances I think the changes are an improvement/are more consistent with other diagnostics (although I'm happy to revert any which seem worse)

@rustbot
Copy link
Collaborator

rustbot commented Apr 8, 2023

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 8, 2023
@matthewjasper matthewjasper mentioned this pull request Apr 8, 2023
84 tasks
@clubby789 clubby789 force-pushed the builtin-macros-translatable branch from e4c55da to 64d2234 Compare April 9, 2023 03:49
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment

@clubby789 clubby789 force-pushed the builtin-macros-translatable branch 2 times, most recently from 48260ef to 37b1f96 Compare April 10, 2023 15:57
@clubby789 clubby789 force-pushed the builtin-macros-translatable branch from 37b1f96 to 64f7597 Compare April 10, 2023 20:17
@rustbot rustbot added the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Apr 10, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 10, 2023

rustc_macros::diagnostics was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @TaKO8Ki

@compiler-errors
Copy link
Member

ty

@bors delegate+

r=me when green

@bors
Copy link
Collaborator

bors commented Apr 10, 2023

✌️ @clubby789 can now approve this pull request

@clubby789
Copy link
Contributor Author

@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented Apr 10, 2023

📌 Commit 64f7597 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2023
@bors
Copy link
Collaborator

bors commented Apr 11, 2023

⌛ Testing commit 64f7597 with merge 45749b2...

@bors
Copy link
Collaborator

bors commented Apr 11, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 45749b2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 11, 2023
@bors bors merged commit 45749b2 into rust-lang:master Apr 11, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 11, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (45749b2): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.4% [-0.4%, -0.4%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.4% [-0.4%, -0.4%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.7% [0.6%, 0.9%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.9% [-3.3%, -0.4%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.6% [-3.3%, 0.9%] 4

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.5% [0.4%, 0.6%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.1% [-2.3%, -2.0%] 3
All ❌✅ (primary) 0.5% [0.4%, 0.6%] 2

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 8, 2023
…henkov

Remove accidental comment

Left this in in rust-lang#110092 while debugging, thanks to `@WaffleLapkin` for spotting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants