unused_parens now fires on cast expression #110189
+355
−47
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| // check-pass | ||
|
|
||
| #![warn(unused_parens)] | ||
|
|
||
| struct Foo(f32); | ||
|
|
||
| impl Foo { | ||
| pub fn f32(self) -> f32 { | ||
| 64.0f32 | ||
| } | ||
| } | ||
|
|
||
| fn bar() -> f32 { | ||
| 3.0f32 | ||
| } | ||
|
|
||
| mod inner { | ||
| pub mod yet_inner { | ||
| pub mod most_inner { | ||
| pub static VERY_LONG_PATH: f32 = 99.0f32; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| fn basic_test() { | ||
| // should fire | ||
| let one = 1.0f32; | ||
| let _ = (one) as f64; | ||
| //~^ WARN unnecessary parentheses around cast expression | ||
| let _ = (inner::yet_inner::most_inner::VERY_LONG_PATH) as f64; | ||
| //~^ WARN unnecessary parentheses around cast expression | ||
| let _ = (Foo(1.0f32).0) as f64; | ||
| //~^ WARN unnecessary parentheses around cast expression | ||
| let _ = (Foo(1.0f32).f32()) as f64; | ||
| //~^ WARN unnecessary parentheses around cast expression | ||
| let _ = (bar()) as f64; | ||
| //~^ WARN unnecessary parentheses around cast expression | ||
| let baz = [4.0f32]; | ||
| let _ = (baz[0]) as f64; | ||
| //~^ WARN unnecessary parentheses around cast expression | ||
| // following is technically unnecessary, but is allowed because it may confusing. | ||
| let _ = (-1.0f32) as f64; | ||
| let x = Box::new(-1.0f32); | ||
| let _ = (*x) as f64; | ||
| //~^ WARN unnecessary parentheses around cast expression | ||
| // cast is left-assoc | ||
| let _ = (true as u8) as u16; | ||
| //~^ WARN unnecessary parentheses around cast expression | ||
| // should not fire | ||
|
There was a problem hiding this comment. Please add unary There was a problem hiding this comment. Does your intention include |
||
| let _ = (1.0f32 * 2.0f32) as f64; | ||
| let _ = (1.0f32 / 2.0f32) as f64; | ||
| let _ = (1.0f32 % 2.0f32) as f64; | ||
| let _ = (1.0f32 + 2.0f32) as f64; | ||
| let _ = (1.0f32 - 2.0f32) as f64; | ||
| let _ = (42 << 1) as i64; | ||
| let _ = (42 >> 1) as i64; | ||
| let _ = (42 & 0x1F) as f64; | ||
| let _ = (42 ^ 0x1F) as f64; | ||
| let _ = (42 | 0x1F) as f64; | ||
| let _ = (1.0f32 == 2.0f32) as u8; | ||
| let _ = (1.0f32 != 2.0f32) as u8; | ||
| let _ = (1.0f32 < 2.0f32) as u8; | ||
| let _ = (1.0f32 > 2.0f32) as u8; | ||
| let _ = (1.0f32 <= 2.0f32) as u8; | ||
| let _ = (1.0f32 >= 2.0f32) as u8; | ||
| let _ = (true && false) as u8; | ||
| let _ = (true || false) as u8; | ||
| // skipped range: `as`-cast does not allow non-primitive cast | ||
| // also skipped compound operator | ||
| } | ||
|
|
||
| fn issue_88519() { | ||
| let _ = ({ 1 }) as i64; | ||
| let _ = (match 0 { x => x }) as i64; | ||
| let _ = (if true { 16 } else { 42 }) as i64; | ||
| } | ||
|
|
||
| fn issue_51185() -> impl Into<for<'a> fn(&'a ())> { | ||
| // removing parens will change semantics, and make compile does not pass | ||
| (|_| {}) as for<'a> fn(&'a ()) | ||
| } | ||
|
|
||
| fn issue_clippy_10557() { | ||
| let x = 0f32; | ||
| let y = 0f32; | ||
| let width = 100f32; | ||
| let height = 100f32; | ||
|
|
||
| new_rect((x) as f64, (y) as f64, (width) as f64, (height) as f64); | ||
| //~^ WARN unnecessary parentheses around cast expression | ||
| //~^^ WARN unnecessary parentheses around cast expression | ||
| //~^^^ WARN unnecessary parentheses around cast expression | ||
| //~^^^^ WARN unnecessary parentheses around cast expression | ||
| } | ||
|
|
||
| fn new_rect(x: f64, y: f64, width: f64, height: f64) { | ||
|
|
||
| } | ||
|
|
||
| fn main() { | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,151 @@ | ||
| warning: unnecessary parentheses around cast expression | ||
| --> $DIR/unused_parens_cast.rs:28:13 | ||
| | | ||
| LL | let _ = (one) as f64; | ||
| | ^ ^ | ||
| | | ||
| note: the lint level is defined here | ||
| --> $DIR/unused_parens_cast.rs:3:9 | ||
| | | ||
| LL | #![warn(unused_parens)] | ||
| | ^^^^^^^^^^^^^ | ||
| help: remove these parentheses | ||
| | | ||
| LL - let _ = (one) as f64; | ||
| LL + let _ = one as f64; | ||
| | | ||
|
|
||
| warning: unnecessary parentheses around cast expression | ||
| --> $DIR/unused_parens_cast.rs:30:13 | ||
| | | ||
| LL | let _ = (inner::yet_inner::most_inner::VERY_LONG_PATH) as f64; | ||
| | ^ ^ | ||
| | | ||
| help: remove these parentheses | ||
| | | ||
| LL - let _ = (inner::yet_inner::most_inner::VERY_LONG_PATH) as f64; | ||
| LL + let _ = inner::yet_inner::most_inner::VERY_LONG_PATH as f64; | ||
| | | ||
|
|
||
| warning: unnecessary parentheses around cast expression | ||
| --> $DIR/unused_parens_cast.rs:32:13 | ||
| | | ||
| LL | let _ = (Foo(1.0f32).0) as f64; | ||
| | ^ ^ | ||
| | | ||
| help: remove these parentheses | ||
| | | ||
| LL - let _ = (Foo(1.0f32).0) as f64; | ||
| LL + let _ = Foo(1.0f32).0 as f64; | ||
| | | ||
|
|
||
| warning: unnecessary parentheses around cast expression | ||
| --> $DIR/unused_parens_cast.rs:34:13 | ||
| | | ||
| LL | let _ = (Foo(1.0f32).f32()) as f64; | ||
| | ^ ^ | ||
| | | ||
| help: remove these parentheses | ||
| | | ||
| LL - let _ = (Foo(1.0f32).f32()) as f64; | ||
| LL + let _ = Foo(1.0f32).f32() as f64; | ||
| | | ||
|
|
||
| warning: unnecessary parentheses around cast expression | ||
| --> $DIR/unused_parens_cast.rs:36:13 | ||
| | | ||
| LL | let _ = (bar()) as f64; | ||
| | ^ ^ | ||
| | | ||
| help: remove these parentheses | ||
| | | ||
| LL - let _ = (bar()) as f64; | ||
| LL + let _ = bar() as f64; | ||
| | | ||
|
|
||
| warning: unnecessary parentheses around cast expression | ||
| --> $DIR/unused_parens_cast.rs:39:13 | ||
| | | ||
| LL | let _ = (baz[0]) as f64; | ||
| | ^ ^ | ||
| | | ||
| help: remove these parentheses | ||
| | | ||
| LL - let _ = (baz[0]) as f64; | ||
| LL + let _ = baz[0] as f64; | ||
| | | ||
|
|
||
| warning: unnecessary parentheses around cast expression | ||
| --> $DIR/unused_parens_cast.rs:44:13 | ||
| | | ||
| LL | let _ = (*x) as f64; | ||
| | ^ ^ | ||
| | | ||
| help: remove these parentheses | ||
| | | ||
| LL - let _ = (*x) as f64; | ||
| LL + let _ = *x as f64; | ||
| | | ||
|
|
||
| warning: unnecessary parentheses around cast expression | ||
| --> $DIR/unused_parens_cast.rs:47:13 | ||
| | | ||
| LL | let _ = (true as u8) as u16; | ||
| | ^ ^ | ||
| | | ||
| help: remove these parentheses | ||
| | | ||
| LL - let _ = (true as u8) as u16; | ||
| LL + let _ = true as u8 as u16; | ||
| | | ||
|
|
||
| warning: unnecessary parentheses around cast expression | ||
| --> $DIR/unused_parens_cast.rs:89:14 | ||
| | | ||
| LL | new_rect((x) as f64, (y) as f64, (width) as f64, (height) as f64); | ||
| | ^ ^ | ||
| | | ||
| help: remove these parentheses | ||
| | | ||
| LL - new_rect((x) as f64, (y) as f64, (width) as f64, (height) as f64); | ||
| LL + new_rect(x as f64, (y) as f64, (width) as f64, (height) as f64); | ||
| | | ||
|
|
||
| warning: unnecessary parentheses around cast expression | ||
| --> $DIR/unused_parens_cast.rs:89:26 | ||
| | | ||
| LL | new_rect((x) as f64, (y) as f64, (width) as f64, (height) as f64); | ||
| | ^ ^ | ||
| | | ||
| help: remove these parentheses | ||
| | | ||
| LL - new_rect((x) as f64, (y) as f64, (width) as f64, (height) as f64); | ||
| LL + new_rect((x) as f64, y as f64, (width) as f64, (height) as f64); | ||
| | | ||
|
|
||
| warning: unnecessary parentheses around cast expression | ||
| --> $DIR/unused_parens_cast.rs:89:38 | ||
| | | ||
| LL | new_rect((x) as f64, (y) as f64, (width) as f64, (height) as f64); | ||
| | ^ ^ | ||
| | | ||
| help: remove these parentheses | ||
| | | ||
| LL - new_rect((x) as f64, (y) as f64, (width) as f64, (height) as f64); | ||
| LL + new_rect((x) as f64, (y) as f64, width as f64, (height) as f64); | ||
| | | ||
|
|
||
| warning: unnecessary parentheses around cast expression | ||
| --> $DIR/unused_parens_cast.rs:89:54 | ||
| | | ||
| LL | new_rect((x) as f64, (y) as f64, (width) as f64, (height) as f64); | ||
| | ^ ^ | ||
| | | ||
| help: remove these parentheses | ||
| | | ||
| LL - new_rect((x) as f64, (y) as f64, (width) as f64, (height) as f64); | ||
| LL + new_rect((x) as f64, (y) as f64, (width) as f64, height as f64); | ||
| | | ||
|
|
||
| warning: 12 warnings emitted | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -16,6 +16,6 @@ impl Foo for A { | ||
|
|
||
| pub fn main() { | ||
| let a = A { x: 3 }; | ||
| let b = &a as &dyn Foo; | ||
| assert_eq!(b.f(), 3); | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should lint against
(-expr) as i32. Looking at-expr as i32I have no idea whether theasor the-are executed first, and I might care about that (in particular when casting to an unsigned type). (The formatting indicates that-goes first but I don't know if that actually matches how this is parsed.)Parentheses to disambiguate parsing precedence are a good thing, we should not steer people away from them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agreed :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The diff in the Miri test can hopefully be removed then. :)