Skip to content

Rollup of 4 pull requests #110405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 16, 2023
Merged

Rollup of 4 pull requests #110405

merged 8 commits into from
Apr 16, 2023

Conversation

fee1-dead
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Noratrieb and others added 8 commits April 16, 2023 12:05
@Noratrieb
Move some utils out of rustc_const_eval
2109fe4 
This allows us to get rid of the `rustc_const_eval->rustc_borrowck`
dependency edge which was delaying the compilation of borrowck.

The added utils in `rustc_middle` are small and should not affect
compile times there.
@matthiaskrgr
use matches! macro in more places
bcc15bb
@matthiaskrgr
more clippy fixes: clippy::{iter_cloned_collect, unwarp_or_else_defau…
6ef8648 
…lt, option_map_or_none}
@scottmcm
Remove the loop in Align::from_bytes
99fd9cb 
Perf is almost certainly irrelevant, but might as well simplify it, since `trailing_zeros` does exactly what's needed.
@fee1-dead
Rollup merge of rust-lang#110397 - Nilstrieb:speedy-bootstrap-2, r=fe…
508d661 
…e1-dead,jyn514

Move some utils out of `rustc_const_eval`

This allows us to get rid of the `rustc_const_eval->rustc_borrowck` dependency edge which was delaying the compilation of borrowck.

The added utils in `rustc_middle` are small and should not affect compile times there.
@fee1-dead
Rollup merge of rust-lang#110398 - matthiaskrgr:clippy_match, r=Nilst…
fba49a7 
…rieb,fee1-dead

use matches! macro in more places

r? `@Nilstrieb`
@fee1-dead
Rollup merge of rust-lang#110400 - matthiaskrgr:style_mix, r=fee1-dead
1d30adb 
more clippy fixes: clippy::{iter_cloned_collect, unwarp_or_else_defau…

…lt, option_map_or_none}

r? `@Nilstrieb`
@fee1-dead
Rollup merge of rust-lang#110402 - scottmcm:align-tz, r=fee1-dead
38215fb 
Remove the loop in `Align::from_bytes`

Perf is almost certainly irrelevant, but might as well simplify it, since `trailing_zeros` does exactly what's needed.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Apr 16, 2023
@fee1-dead
Copy link
Member Author

@bors r+ rollup=never p=4

@bors
Copy link
Collaborator

bors commented Apr 16, 2023

📌 Commit 38215fb has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2023
@fee1-dead
Copy link
Member Author

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 16, 2023
@fee1-dead fee1-dead closed this Apr 16, 2023
@fee1-dead fee1-dead reopened this Apr 16, 2023
@fee1-dead
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 16, 2023

📌 Commit 38215fb has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 16, 2023
@bors
Copy link
Collaborator

bors commented Apr 16, 2023

⌛ Testing commit 38215fb with merge 8a778ca...

@bors
Copy link
Collaborator

bors commented Apr 16, 2023

☀️ Test successful - checks-actions
Approved by: fee1-dead
Pushing 8a778ca to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Apr 16, 2023

☀️ Test successful - checks-actions
Approved by: fee1-dead
Pushing 8a778ca to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 16, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha

previous master: 8a778ca1e3

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@bors bors merged commit 8a778ca into rust-lang:master Apr 16, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 16, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha
#110402 a5bf4d17e82123729d7f31b218326e511281cdb9
#110400 664e9cba4e9058fa5134ec99bd6b04dc48aa2f5f
#110398 a9193f3963311eb7f2bceca0ac96601e8dd1c783
#110397 752e76c36df562eb2b5cf4fa860c7b29e35c55f6

previous master: 1b50ea9abb

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@bors bors mentioned this pull request Apr 16, 2023
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8a778ca): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.1% [1.3%, 2.6%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.3% [2.3%, 2.3%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
7 participants
@fee1-dead @bors @rust-timer @rustbot @Noratrieb @matthiaskrgr @scottmcm