Rollup of 8 pull requests #110408
Closed
Rollup of 8 pull requests #110408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These traits exist so that folders/visitors can recurse into types of interest: binders, types, regions, predicates, and consts. But `Region` is non-recursive and cannot contain other types of interest, so its methods in these traits are trivial. This commit inlines and removes those trivial methods.
This gets rid of a blocking dependency edge from `rustc_lint->rustc_analysis->rustc_hir_typeck->rustc_interface`
This allows us to get rid of the `rustc_const_eval->rustc_borrowck` dependency edge which was delaying the compilation of borrowck. The added utils in `rustc_middle` are small and should not affect compile times there.
…lt, option_map_or_none}
Perf is almost certainly irrelevant, but might as well simplify it, since `trailing_zeros` does exactly what's needed.
…, r=oli-obk Remove `remap_env_constness` in queries This removes some of the complexities with const traits. rust-lang#88119 used to be caused by this but was fixed by `param_env = param_env.without_const()`.
…ion, r=compiler-errors
Remove `TypeSuper{Foldable,Visitable}` impls for `Region`.
These traits exist so that folders/visitors can recurse into types of interest: binders, types, regions, predicates, and consts. But `Region` is non-recursive and cannot contain other types of interest, so its methods in these traits are trivial.
This commit inlines and removes those trivial methods.
r? ``@compiler-errors``
Use lint via `lint_defs` instead of `lints` This gets rid of a blocking dependency edge from `rustc_lint->rustc_analysis->rustc_hir_typeck->rustc_interface` 
…e1-dead,jyn514 Move some utils out of `rustc_const_eval` This allows us to get rid of the `rustc_const_eval->rustc_borrowck` dependency edge which was delaying the compilation of borrowck. The added utils in `rustc_middle` are small and should not affect compile times there.
…rieb,fee1-dead use matches! macro in more places r? ``@Nilstrieb``
more clippy fixes: clippy::{iter_cloned_collect, unwarp_or_else_defau…
…lt, option_map_or_none}
r? ``@Nilstrieb``
Remove the loop in `Align::from_bytes` Perf is almost certainly irrelevant, but might as well simplify it, since `trailing_zeros` does exactly what's needed.
fix clippy::toplevel_ref_arg and ::manual_map r? `@Nilstrieb`
rustbot
added
A-query-system
|
@bors r+ rollup=never p=8 |
bors
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
remap_env_constnessin queries #109665 (Removeremap_env_constnessin queries)TypeSuper{Foldable,Visitable}impls forRegion. #110345 (RemoveTypeSuper{Foldable,Visitable}impls forRegion.)lint_defsinstead oflints#110396 (Use lint vialint_defsinstead oflints)rustc_const_eval#110397 (Move some utils out ofrustc_const_eval)Align::from_bytes#110402 (Remove the loop inAlign::from_bytes)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup