Allow overwriting the sysroot compile flag in compile tests #110584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-testsuite
oli-obk
reviewed
Apr 20, 2023
Veykril
force-pushed
the
comptest-sysroot-arg
branch
from
e71fb10 to
e434b5b
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 20, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#110240 (Add `indent_style = tab` for `Makefile`s to `.editorconfig`) - rust-lang#110545 (Add `GenericArgKind::as_{type,const,region}`) - rust-lang#110574 ( fix out-of-date comment about rpath in bootstrap) - rust-lang#110581 (Style fix for loongarch-linux.md) - rust-lang#110584 (Allow overwriting the sysroot compile flag in compile tests) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added in https://github.com/rust-lang/rust/pull/110478/files#diff-03a0567fa80ca04ed5a55f9ac5c711b4f84659be2d0ac4a984196d581c04f76b, unconditionally passing the
sysrootflag to the compile test invocations. In our ferrocene fork we have a few tests that test thesysrootflag specifically which fail due to the flag being passed multiple times now.We believe upstreaming this small change could be beneficial should rust-lang/rust also want to test certain sysroot setups in the future.