Skip to content

Add some missing built-in lints #110913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 28, 2023
Merged

Add some missing built-in lints #110913

merged 3 commits into from
Apr 28, 2023

Conversation

compiler-errors
Copy link
Member

(and also sort them, so this is best reviewed one commit at a time)

Fixes #110911

I wonder if there's a good way to detect when a lint is built-in (i.e. not associated to a lint pass). If so, it needs to be added to this list, or else we're unable to allow or deny it. Leaving that for future work, I guess...

@rustbot
Copy link
Collaborator

rustbot commented Apr 27, 2023

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 27, 2023
@peter-lyons-kehl
Copy link
Contributor

Thank you so much.
I confirm that this PR now makes (nightly) match all the rustc lints in Rust documentation (https://doc.rust-lang.org/nightly/rustc/lints/listing/allow-by-default.html, https://doc.rust-lang.org/nightly/rustc/lints/listing/warn-by-default.html, https://doc.rust-lang.org/nightly/rustc/lints/listing/deny-by-default.html). (Used at https://github.com/coop-rs/allows/blob/main/allows/src/lib.rs)

@compiler-errors
Copy link
Member Author

r? @Nilstrieb @bors r=Nilstrieb

@bors
Copy link
Collaborator

bors commented Apr 27, 2023

📌 Commit 0279922 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 28, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 28, 2023
@bors
Auto merge of rust-lang#110924 - matthiaskrgr:rollup-jvznpq2, r=matth…
2fce229 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#110766 (More core::fmt::rt cleanup.)
 - rust-lang#110873 (Migrate trivially translatable `rustc_parse` diagnostics)
 - rust-lang#110904 (rustdoc: rebind bound vars to type-outlives predicates)
 - rust-lang#110913 (Add some missing built-in lints)
 - rust-lang#110918 (`remove_dir_all`: try deleting the directory even if `FILE_LIST_DIRECTORY` access is denied)
 - rust-lang#110920 (Fix unavailable url)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 901bab7 into rust-lang:master Apr 28, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 28, 2023
@compiler-errors compiler-errors deleted the missing-lints branch August 11, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noratrieb Noratrieb Noratrieb approved these changes

Assignees

@Noratrieb Noratrieb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.

invalid_macro_export_arguments rustc lint currently can't be "allowed"
6 participants
@compiler-errors @rustbot @peter-lyons-kehl @bors @Noratrieb @b-naber