Don't ICE on unsized extern "rust-call" call
#111885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
est31
reviewed
May 24, 2023
| #![feature(unboxed_closures)] | ||
| #![feature(unsized_fn_params)] | ||
|
|
||
| fn bad() -> extern "rust-call" fn(([u8],)) { todo!() } |
There was a problem hiding this comment.
I wonder if one should still allow declaring the function. A case could be made for functions with generics as you could call them with a sized type parameter, but if we know that the type is unsized maybe we could error? Or maybe it should be a lint instead? IDK.
There was a problem hiding this comment.
Yeah, I don't know if we could make this a well-formedness check. Maybe a lint, yeah.
|
r? compiler |
|
@compiler-errors you are aware that there are merge conflicts? |
|
@est31: shouldn't affect the reviewability of this PR, but thanks, I'll rebase it soon I guess. |
rust-cloud-vms
bot
force-pushed
the
rust-call-abi-sized
branch
from
4fd27e5 to
b95ea45
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 13, 2023
…iaskrgr Rollup of 2 pull requests Successful merges: - rust-lang#111885 (Don't ICE on unsized `extern "rust-call"` call) - rust-lang#112558 (Fix typo in mod.rs) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conceptually builds on #111864, but doesn't depend on it.