Remove unneeded Buffer allocations when &mut fmt::Write can be used directly
#112243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
notriddle
reviewed
Jun 5, 2023
|
I moved the arguments directly into the string in the lines I updated. Thanks for the suggestion! |
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
…llaumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#112243 (Remove unneeded `Buffer` allocations when `&mut fmt::Write` can be used directly) - rust-lang#112263 (Remove ExtendElement, ExtendWith, extend_with) - rust-lang#112291 (Disable RustAnalyzer check by default, run Rustfmt check before) - rust-lang#112299 (Don't double-print status messages in GHA) - rust-lang#112311 (Ignore fluent message reordering in `git blame`) - rust-lang#112315 (fix spelling error) Failed merges: - rust-lang#112251 (rustdoc: convert `if let Some()` that always matches to variable) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent changes,
wrap_itemcan now directly take&mut Write, which makes someBuffercreations unneeded.r? @notriddle