Don't record adjustments twice in note_source_of_type_mismatch_constraint
#112537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cjgillot (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 18, 2023
…ments-twice, r=cjgillot Don't record adjustments twice in `note_source_of_type_mismatch_constraint` We call `lookup_method` a few times in `note_source_of_type_mismatch_constraint`, but that function has side-effects to the typeck results. Replace it with a less side-effect-y variant of the function for use in diagnostics. Specifically the ICE in rust-lang#112532 happens because we're recording deref adjustments twice for a call receiver, which causes `ExprUseVisitor` to be angry. Fixes rust-lang#112532
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 18, 2023
…mpiler-errors Rollup of 6 pull requests Successful merges: - rust-lang#112537 (Don't record adjustments twice in `note_source_of_type_mismatch_constraint`) - rust-lang#112663 (cleanup azure leftovers) - rust-lang#112668 (Test `x.ps1` in `msvc` CI job) - rust-lang#112710 (Re-use the deref-pattern recursion instead of duplicating the logic) - rust-lang#112753 (Don't try to auto-bless 32-bit `mir-opt` tests on ARM Mac hosts) - rust-lang#112758 (refactor(resolve): delete update_resolution function) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We call
lookup_methoda few times innote_source_of_type_mismatch_constraint, but that function has side-effects to the typeck results. Replace it with a less side-effect-y variant of the function for use in diagnostics.Specifically the ICE in #112532 happens because we're recording deref adjustments twice for a call receiver, which causes
ExprUseVisitorto be angry.Fixes #112532