Suggest bumping download-ci-llvm-stamp if the build config for llvm changes #112619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-meta
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 17, 2023
…acrum Suggest bumping download-ci-llvm-stamp if the build config for llvm changes This will hopefully avoid issues like rust-lang#110474 where the uploaded `rust-dev` component doesn't match the one you'd get if you built LLVM from source. cc rust-lang#110474 (comment)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 17, 2023
…acrum Suggest bumping download-ci-llvm-stamp if the build config for llvm changes This will hopefully avoid issues like rust-lang#110474 where the uploaded `rust-dev` component doesn't match the one you'd get if you built LLVM from source. cc rust-lang#110474 (comment)
This was referenced Jun 17, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 17, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#110805 (Github action to periodically `cargo update` to keep dependencies current) - rust-lang#112435 (Allow overwriting the sysroot compile flag via --rustc-args) - rust-lang#112610 (Bump stdarch) - rust-lang#112619 (Suggest bumping download-ci-llvm-stamp if the build config for llvm changes) - rust-lang#112738 (make ice msg "Unknown runtime phase" a bit nicer) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will hopefully avoid issues like #110474 where the uploaded
rust-devcomponent doesn't match the one you'd get if you built LLVM from source.cc #110474 (comment)