Skip to content

Fixed documentation of from<CString> for Rc<CStr>: Arc -> Rc #113253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2023
Merged

Fixed documentation of from<CString> for Rc<CStr>: Arc -> Rc #113253

merged 1 commit into from
Jul 3, 2023

Conversation

nurmukhametdaniyar
Copy link
Contributor

Fix #113131

@rustbot
Copy link
Collaborator

rustbot commented Jul 2, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 2, 2023
Noratrieb
Noratrieb approved these changes Jul 2, 2023
View reviewed changes
Copy link
Member

@Noratrieb Noratrieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r? Nilstrieb

@rustbot rustbot assigned Noratrieb and unassigned Mark-Simulacrum Jul 2, 2023
@Noratrieb
Copy link
Member

@bors r+ rollup Thanks!

@bors
Copy link
Collaborator

bors commented Jul 2, 2023

📌 Commit 99599db has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 2, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 2, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 3, 2023
@bors
Auto merge of rust-lang#113271 - matthiaskrgr:rollup-2ik4vaj, r=matth…
1623634 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#113253 (Fixed documentation of from<CString> for Rc<CStr>: Arc -> Rc)
 - rust-lang#113258 (Migrate GUI colors test to original CSS color format)
 - rust-lang#113259 (Suggest `x build library` for a custom toolchain that fails to load `core`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 023f72a into rust-lang:master Jul 3, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noratrieb Noratrieb Noratrieb approved these changes

Assignees

@Noratrieb Noratrieb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.

Implementation of From on Rc incorrectly refers to Arc
5 participants
@nurmukhametdaniyar @rustbot @Noratrieb @bors @Mark-Simulacrum