Skip to content

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Jul 3, 2023

Miri for quite a while now has a hack to support self-referential generators: non-Unique mutable references are exempt from aliasing conditions. So we can run this test now. (It passes.)

Also extend a comment in a Vec test, while I am at it.

@rustbot
Copy link
Collaborator

rustbot commented Jul 3, 2023

r? @m-ou-se

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 3, 2023
@JohnTitor
Copy link
Member

Neat! @bors r+ r? @JohnTitor

@bors
Copy link
Collaborator

bors commented Jul 5, 2023

📌 Commit e1338cc has been approved by JohnTitor

It is now in the queue for this repository.

@rustbot rustbot assigned JohnTitor and unassigned m-ou-se Jul 5, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 5, 2023
@bors
Copy link
Collaborator

bors commented Jul 5, 2023

⌛ Testing commit e1338cc with merge d9c13cd...

@bors
Copy link
Collaborator

bors commented Jul 5, 2023

☀️ Test successful - checks-actions
Approved by: JohnTitor
Pushing d9c13cd to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Jul 5, 2023

☀️ Test successful - checks-actions
Approved by: JohnTitor
Pushing d9c13cd to master...

@bors bors added merged-by-bors This PR was explicitly merged by bors. labels Jul 5, 2023
@bors bors merged commit d9c13cd into rust-lang:master Jul 5, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jul 5, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d9c13cd): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.9% [2.9%, 2.9%] 1
Improvements ✅
(primary)
-4.0% [-4.0%, -4.0%] 1
Improvements ✅
(secondary)
-2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) -4.0% [-4.0%, -4.0%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.6% [3.6%, 3.6%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 658.838s -> 658.504s (-0.05%)

@RalfJung RalfJung deleted the miri-test-libstd branch July 6, 2023 14:57
@lqd lqd mentioned this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants