-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Revert "Suggest x build library
for a custom toolchain that fails to load core
"
#113288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @cjgillot (rustbot has picked a reviewer for you, use r? to override) |
@bors r=10 |
📌 Commit 9aad59bf61193af23642d4da1117e647fd8d6e76 has been approved by It is now in the queue for this repository. |
@bors r+ |
📌 Commit 9aad59bf61193af23642d4da1117e647fd8d6e76 has been approved by It is now in the queue for this repository. |
…o load `core`" This reverts commit b913f55. CI builds with profile=nightly, causing different test output. Making the output depend on the release channel was not a great idea.
9aad59b
to
ba0f5dc
Compare
@bors r=oli-obk |
☀️ Test successful - checks-actions |
Finished benchmarking commit (3ae0ef7): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 668.125s -> 670.578s (0.37%) |
This reverts commit b913f55.
CI builds with profile=nightly, causing different test output.
Making the output depend on the release channel was not a great idea and we have to be more careful with this.
I did not realize that the change could have such effects on test output but it's kinda obvious with hindsight >.<.