Fix compiletest windows path finding with spaces #113706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-testsuite
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 1ce6183 with merge 515cc8ea9eee1bc817d053564861dbd4eeed5f62... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
@bors retry 404 |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 18, 2023
…, r=oli-obk Fix compiletest windows path finding with spaces With `(?x)` enabled spaces are ignored unless you escape them, so the space wasn't being added to the character class I don't think this makes any difference to the current test suite, but it could save someone a headache in the future
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 18, 2023
…, r=oli-obk Fix compiletest windows path finding with spaces With `(?x)` enabled spaces are ignored unless you escape them, so the space wasn't being added to the character class I don't think this makes any difference to the current test suite, but it could save someone a headache in the future
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (f0580df): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 657.045s -> 658.423s (0.21%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
(?x)enabled spaces are ignored unless you escape them, so the space wasn't being added to the character classI don't think this makes any difference to the current test suite, but it could save someone a headache in the future