Skip to content

Add FnPtr ty to SMIR #113910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 21, 2023
Merged

Add FnPtr ty to SMIR #113910

merged 4 commits into from
Jul 21, 2023

Conversation

spastorino
Copy link
Member

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 21, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jul 21, 2023

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino

@oli-obk
Copy link
Contributor

oli-obk commented Jul 21, 2023

@bors r+ rollup

ok I'm convinced, this is better than using Lift and thread local storage.

@bors
Copy link
Collaborator

bors commented Jul 21, 2023

📌 Commit 17b8977 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2023
@spastorino
Copy link
Member Author

@bors r=oli-obk

@bors
Copy link
Collaborator

bors commented Jul 21, 2023

📌 Commit 634db10 has been approved by oli-obk

It is now in the queue for this repository.

@matthiaskrgr matthiaskrgr mentioned this pull request Jul 21, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 21, 2023
@bors
Auto merge of rust-lang#113922 - matthiaskrgr:rollup-90cj2vv, r=matth…
c3c5a5c 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#113887 (new solver: add a separate cache for coherence)
 - rust-lang#113910 (Add FnPtr ty to SMIR)
 - rust-lang#113913 (error/E0691: include alignment in error message)
 - rust-lang#113914 (rustc_target: drop duplicate code)

r? `@ghost`
`@rustbot` modify labels: rollup
@spastorino spastorino mentioned this pull request Jul 21, 2023
Merged
@bors bors merged commit b91c41b into rust-lang:master Jul 21, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
4 participants
@spastorino @rustbot @oli-obk @bors