Rollup of 8 pull requests #114024
Merged
Rollup of 8 pull requests #114024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… target. This option is the same as the `thumb_base` defaults used by this target.
GCC uses the `-fshort-enums` ABI for arm-none and the `int`-sized enum ABI for arm-linux. Clang uses the `int`-sized enum ABI for all arm targets. Both options are permitted by AAPCS. Rust is matching GCC's behavior for these targets, as interop with code code compiled by GCC is desirable in the bare-metal context. See rust-lang#87917.
Per rust-lang#112156, using `&` in `format!` may cause a small perf delay, so I tried to clean up one module at a time format usage. This PR includes a few removals of the ref in format (they do compile locally without the ref), as well as a few format inlining for consistency.
Per rust-lang#112156, using `&` in `format!` may cause a small perf delay, so I tried to clean up one module at a time format usage. This PR includes a few removals of the ref in format (they do compile locally without the ref), as well as a few format inlining for consistency.
This came from x86_64-unknown-none and doesn't make sense here.
Co-authored-by: lcnr <[email protected]>
…spastorino add dynamic for smir r? spastorino
…tebank Use erased self type when autoderefing for trait error suggestion Let's not try to pass something from `skip_binder` into autoderef. Fixes rust-lang#113951
Comment stuff in the new solver r? `@lcnr`
arm-none fixups - Remove "-unknown" from `llvm_target` for arm\*v7r-none-eabi\* targets. - Remove redundant `c_enum_min_bits` option from the thumbv4t-none-eabi target. - Fix comments about GCC/Clang's enum width for arm-none targets. Previously part of rust-lang#110482, which is a larger change to add a new target. These nits were found along the way.
…Lapkin Optimize format usage Per rust-lang#112156, using `&` in `format!` may cause a small perf delay, so I tried to clean up one module at a time format usage. This PR includes a few removals of the ref in format (they do compile locally without the ref), as well as a few format inlining for consistency.
Optimize format usage Per rust-lang#112156, using `&` in `format!` may cause a small perf delay, so I tried to clean up one module at a time format usage. This PR includes a few removals of the ref in format (they do compile locally without the ref), as well as a few format inlining for consistency.
…wn-readme, r=Amanieu Update sparc-unknown-none-elf platform README Cherry picked a couple of commits that didn't quite make it in rust-lang#113535
…r=lcnr Add missing documentation for `Session::time` r? `@lcnr`
rustbot
added
S-waiting-on-review
|
@bors r+ rollup=never p=8 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: cb6ab9516b In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (fc8a3e3): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 653.106s -> 652.768s (-0.05%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Session::time#114021 (Add missing documentation forSession::time)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup