Skip to content

Conversation

eminence
Copy link
Contributor

In general, you can run "rustpkg help " to see some specific usage information for . However, this was handled in a very ad-hoc and buggy manner. For example, running "rustpkg help prefer" would actually show you the usage information for the "uninstall" cmd. Or "rustpkg help test" would show you the usage information for the "build" command. Or "rustpkg help list" would just run the "list" command (and not show you anything usage information)

This commit attempts to fix this by making a new HelpCmd (and handling it explicitly)

In general, you could run "rustpkg help <cmd>" to see some specific
usage information for <cmd>.  However, this was handled in a very ad-hoc
and buggy manner.  For example, running "rustpkg help prefer" would
actually show you the usage information for the "uninstall" cmd.

This commit attempts to fix this by making Help a real Command, and
making the handing of it explicit.
@klutzy
Copy link
Contributor

klutzy commented Jan 11, 2014

Could you fix lib.rs#L387 too? It currently prints uninstall help for rustpkg prefer.

@eminence
Copy link
Contributor Author

Good catch. I've added a commit that fixes that too.

bors added a commit that referenced this pull request Jan 11, 2014
In general, you can run "rustpkg help <cmd>" to see some specific usage information for <cmd>.  However, this was handled in a very ad-hoc and buggy manner.  For example, running "rustpkg help prefer" would actually show you the usage information for the "uninstall" cmd.  Or "rustpkg help test" would show you the usage information for the "build" command.  Or "rustpkg help list" would just run the "list" command (and not show you anything usage information)

This commit attempts to fix this by making a new HelpCmd (and handling it explicitly)
@bors bors closed this Jan 11, 2014
@bors bors merged commit dc21ca9 into rust-lang:master Jan 11, 2014
@eminence eminence deleted the rustpkg_help_test branch January 11, 2014 20:20
flip1995 pushed a commit to flip1995/rust that referenced this pull request Sep 25, 2023
…=dswij

Ignore span's parents in `collect_ast_format_args`/`find_format_args`

Fixes rust-lang#11470, covers some cases missed by rust-lang#10980

Can't have a test yet because of rust-lang#11126 but it works locally

changelog: none

r? `@dswij`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants