Define arch for iOS/ARM #11472
Merged
Define arch for iOS/ARM #11472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1160,6 +1160,7 @@ pub mod types { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(target_arch = "arm")] | |||
There was a problem hiding this comment.
Does Android need it too?
There was a problem hiding this comment.
Android has some arm/x86 switches in this file already.
There was a problem hiding this comment.
Ok, but I think that targetting on ARM with target_arch = "arm" will trigger it for Android too, no? Does that have any side effect?
There was a problem hiding this comment.
The change is within a #[cfg(target_os = "macos")] block.
There was a problem hiding this comment.
It find it easy to get lost in this file.
bors
added a commit
that referenced
this pull request
Jan 11, 2014
This fixes #11336 I guess the type sizes are correct for both OS X and iOS, but i am not certain. In any case, i'd rather have any iOS build at all, so that we have something to improve upon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11336
I guess the type sizes are correct for both OS X and iOS, but i am not certain.
In any case, i'd rather have any iOS build at all, so that we have something to improve upon.