Skip to content

Conversation

RalfJung
Copy link
Member

Always better to avoid a transmute, in particular when the layout assumptions it is making are not clearly documented. :)

@rustbot
Copy link
Collaborator

rustbot commented Aug 14, 2023

r? @m-ou-se

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 14, 2023
@m-ou-se
Copy link
Member

m-ou-se commented Aug 15, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 15, 2023

📌 Commit f2172ea has been approved by m-ou-se

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2023
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 16, 2023
avoid transmuting Box when we can just cast raw pointers instead

Always better to avoid a transmute, in particular when the layout assumptions it is making are not clearly documented. :)
@bors
Copy link
Collaborator

bors commented Aug 17, 2023

⌛ Testing commit f2172ea with merge bd138e2...

@bors
Copy link
Collaborator

bors commented Aug 17, 2023

☀️ Test successful - checks-actions
Approved by: m-ou-se
Pushing bd138e2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 17, 2023
@bors bors merged commit bd138e2 into rust-lang:master Aug 17, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 17, 2023
@RalfJung RalfJung deleted the less-transmute branch August 17, 2023 12:19
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bd138e2): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.0% [2.0%, 2.0%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.2% [-3.2%, -3.2%] 1
Improvements ✅
(secondary)
-4.0% [-4.0%, -4.0%] 2
All ❌✅ (primary) -0.6% [-3.2%, 2.0%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.7% [0.7%, 0.7%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.7% [-2.7%, -2.7%] 1
All ❌✅ (primary) 0.7% [0.7%, 0.7%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 634.954s -> 632.38s (-0.41%)
Artifact size: 347.10 MiB -> 347.07 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants