Skip to content

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Aug 15, 2023

Merge the current release/17.x branch.

Fixes #114691.
Fixes #114312.

The test for the latter is taken from #114726.

@rustbot
Copy link
Collaborator

rustbot commented Aug 15, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Aug 15, 2023

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 15, 2023
@nikic
Copy link
Contributor Author

nikic commented Aug 15, 2023

r? @cuviper

@rustbot rustbot assigned cuviper and unassigned petrochenkov Aug 15, 2023
@cuviper
Copy link
Member

cuviper commented Aug 15, 2023

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Aug 15, 2023

📌 Commit c12c084 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2023
@bors
Copy link
Collaborator

bors commented Aug 16, 2023

⌛ Testing commit c12c084 with merge 748fa57d065c1803f6486db17e0a3070a450ff78...

@bors
Copy link
Collaborator

bors commented Aug 16, 2023

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 748fa57d065c1803f6486db17e0a3070a450ff78 to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Aug 16, 2023

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 748fa57d065c1803f6486db17e0a3070a450ff78 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 16, 2023
@bors
Copy link
Collaborator

bors commented Aug 16, 2023

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

1 similar comment
@bors
Copy link
Collaborator

bors commented Aug 16, 2023

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (748fa57d065c1803f6486db17e0a3070a450ff78): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.1% [3.1%, 3.1%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.0% [-4.3%, -3.7%] 2
All ❌✅ (primary) 3.1% [3.1%, 3.1%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.0% [1.0%, 1.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 633.84s -> 635.35s (0.24%)
Artifact size: 346.89 MiB -> 346.84 MiB (-0.01%)

@cuviper
Copy link
Member

cuviper commented Aug 16, 2023

@bors retry

@bors
Copy link
Collaborator

bors commented Aug 16, 2023

⌛ Testing commit c12c084 with merge 2bc7929...

@bors
Copy link
Collaborator

bors commented Aug 16, 2023

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 2bc7929 to master...

@bors bors merged commit 2bc7929 into rust-lang:master Aug 16, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 16, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2bc7929): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.5% [-0.6%, -0.3%] 8
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.2% [1.3%, 3.0%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.2% [-3.2%, -3.2%] 2
All ❌✅ (primary) 2.2% [1.3%, 3.0%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 635.544s -> 634.431s (-0.18%)
Artifact size: 346.78 MiB -> 346.89 MiB (0.03%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Miscompilation when matching on an enum after printing Hello world Recursion using extern "C" causes miscompilation
7 participants