Improve note for the invalid_reference_casting lint
#115102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
est31
approved these changes
Aug 23, 2023
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 23, 2023
…e, r=est31 Improve note for the `invalid_reference_casting` lint This PR add link to the book interior mutability chapter, https://doc.rust-lang.org/book/ch15-05-interior-mutability.html; this is done to guide peoples to a place with many useful information and context. *Note that this isn't the first occurrence of a link to the book in [tests outputs](https://github.com/search?q=repo%3Arust-lang%2Frust+book+path%3A%2F%5Etests%5C%2Fui%5C%2F%2F&type=code).* r? `@est31`
Add link to the book interior mutability chapter, https://doc.rust-lang.org/book/ch15-05-interior-mutability.html.
Urgau
force-pushed
the
invalid_ref_casting-book-note
branch
from
e707f1a to
aa77300
Compare
|
Rebased on top of #115100, due to the test output changes. Needs to be re-approved. |
|
Hmm yeah I should maybe not have approved both at the same time as it failed later when trying the rollup. But shrug. @bors r+ |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 23, 2023
…llaumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#114696 (Fix a pthread_t handle leak rust-lang#114610) - rust-lang#115102 (Improve note for the `invalid_reference_casting` lint) - rust-lang#115103 (Disable bootstrap rustc version check) - rust-lang#115106 (ArchiveWrapper: handle LLVM API update) - rust-lang#115109 (Skip ExpandYamlAnchors when the config is missing) - rust-lang#115135 (Rustdoc: Add unstable --no-html-source flag) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add link to the book interior mutability chapter, https://doc.rust-lang.org/book/ch15-05-interior-mutability.html; this is done to guide peoples to a place with many useful information and context.
Note that this isn't the first occurrence of a link to the book in tests outputs.
r? @est31